Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quest phasing done on complete, not turn-in #10725

Closed
wkoot opened this issue Sep 6, 2013 · 23 comments
Closed

Quest phasing done on complete, not turn-in #10725

wkoot opened this issue Sep 6, 2013 · 23 comments

Comments

@wkoot
Copy link

wkoot commented Sep 6, 2013

It seems that quest phase changes are done on completing quests, instead of when turning them in to the questgiver.

Examples:
The Last Line Of Defense - http://www.wowhead.com/quest=13086
The Battle For Crusaders' Pinnacle - http://www.wowhead.com/quest=13141

Especially in the case of The Last Line Of Defense, you get phased out of the phase that holds the npc to turn the quest in. Thus getting stuck ;-)

revision: f5f3ea0

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Anonymous2
Copy link

Can you propose a fix?

@jtrudell88
Copy link

Any fix? This is still happening but i am stuck at "A Cold Front Approaches"

@ghost
Copy link

ghost commented Jun 3, 2014

@jtrudell88 : Have you tried going inside the NPC Siegemaster Fezzik's hut? I was able to make him appear by entering the goblin's shed and backing out again, then he appears. The problem I got is that the quest text is not present, only the title of the quest. Also, the [Complete] button is gray, so I still can't progress before I get a GM char to complete the quest.

@jtrudell88
Copy link

i see the guy now but when i clicked on the text and walked out and back in, i was able to turn in the quest and get to the next quest but the phasing didnt start until i logged off. Now the cannon shows up under this platform and i cant use it because it says i am too far away

@ghost
Copy link

ghost commented Jun 4, 2014

Sounds like your server does not get correct character coordinates, or there is something wrong with the GO interaction. Not sure what is happening there. 😕

@jtrudell88
Copy link

its a fresh compiled server that i made 2 days ago.
Core Revision: 0c1ddc9

@ghost
Copy link

ghost commented Jun 4, 2014

Add core hash to your comment, I'll test on a new compile and come back with test result at a later time.

@jtrudell88
Copy link

k, thanks

@untaught
Copy link
Contributor

untaught commented Jun 4, 2014

Check flags in http://collab.kpsn.org/display/tc/spell_area.

@jtrudell88
Copy link

i got it to work by recreating the world database. i forgot i tried something and it messed it up. but there is an issue with the non-elites keep evading on me

@Rushor
Copy link
Contributor

Rushor commented Jun 4, 2014

look how the elite npcs behave and try to compare them with each other to find the issue :D

@jtrudell88
Copy link

the elites can fly and the others are just spider scourge that are on the ground and if they dont get killed but i aggro them, they come crawling up to the platform and evade out

@ghost
Copy link

ghost commented Feb 12, 2015

The Battle For Crusaders' Pinnacle (http://www.wowhead.com/quest=13141) - see new issue #14125

@ccrs
Copy link
Member

ccrs commented Feb 13, 2015

Just as #14125 evrything can be solved by setting the correct mission and status.

@ghost
Copy link

ghost commented Feb 13, 2015

Core Hash Rev.: c5dac48
TDB 335.57 + updates including 2015_02_12_06

Mob evade issue still present on the cannon turret quest, but I suppose that is a different issue.
Phasing issue in #14125 is solved and could be used if the NPC Siegemaster Fezzik still has this issue.
(I forgot to check this time around) I was so focused on #14125 and The Battle For Crusaders' Pinnacle that I forgot to notice which issues are present and which are not on Fezzik. I think I remember that he still does that fading depending on whether you move inside the hut or not. Read #14125 for more info regarding running the entire questline in the Argent Vanguard / Crusaders' Pinnacle.

Edit: The Last Line Of Defense - http://www.wowhead.com/quest=13086/the-last-line-of-defense
Quest NPC Siegemaster Fezzik: http://www.wowhead.com/npc=30657/siegemaster-fezzik

Evade issue still present. Quest NPC not entirely phased out, only when you stand outside of the hut.
If Fezzik is not supposed to be phased at all, try changing the NPC ID & quest ID in this SQL query:

UPDATE `spell_area` SET `quest_end`='13157', `quest_end_status`='1' WHERE `spell`='57674' and `area`='4504' and `quest_start`='13086' and `aura_spell`='0' and `racemask`='0' and `gender`='2';

Note: the only modification from the original is an extra space after each 'and' operator for visual esthetics.

@ccrs
Copy link
Member

ccrs commented Feb 14, 2015

Problem with Fezzik seems to be that spell_area fails/gets unnecessary update on entering the hut. Looks like its the same area but "zone" changes as can be seen on minimap (just random guess).

@Killyana
Copy link
Member

The Phasing is broken once the player takes http://www.wowhead.com/quest=13070/a-cold-front-approaches

@ccrs
Copy link
Member

ccrs commented Apr 30, 2015

Not really, just get in and out the hut.

@ghost
Copy link

ghost commented Apr 30, 2015

@ccrs : I think Killyana is referring to more issues than just NPC Siegemaster Fezzik - like the cannon tower - as well as the fact that the phase threshold in that hut should not be there if your character is in the right phase. (Correct me if I have misunderstood it.)

Edit: Killyana is correcting the OP, which says that the phasing is broken for [The Last Line Of Defense] and [The Battle For Crusaders' Pinnacle]. What Killyana says is happening instead, is that this happens already when you get [A Cold Front Approaches] from [Highlord Tirion Fordring] in the Argent Vanguard.

@Killyana : can anything be done in conditions, or is this zone-script based?

@wkoot
Copy link
Author

wkoot commented May 6, 2015

No, what I'm saying is that the moment of phase change is wrong. Those two quests are examples.
Instead of COMPLETE > CHANGE PHASE > TURN IN, it should be COMPLETE > TURN IN > CHANGE PHASE.

@ccrs
Copy link
Member

ccrs commented May 6, 2015

@wkoot seems like it can be corrected in spell_area

@Killyana
Copy link
Member

Killyana commented Jul 4, 2016

Looks to be a core issue, I will try to explain how the phasing works for this 2 quests (13070, 13141)

Phase 1: Set by the spell 57673, starts= none, ends= quest 13070 Rewarded
Phase 2: Set by the spell 57569, starts= quest 13070 Rewards, ends= quest 13086 Rewarded

Notice: The condition "quest 13070 Rewarded" is used to remove the aura 57673 and set the aura 57569, the problem here is the cast of 57569 fails. Looks like the spell is casted before the state of the quest changes.

To understand the issue enter the area, .quest add 13070 then .cast 57569 , you will get the message "you're in the wrong area" actually the area is not wrong but the condition to cast the spell is not met, and I think this happen when the quest 13086 is rewarded, as it tries to cast the spell before the quest status changes for the player.

@SnapperRy
Copy link
Contributor

SnapperRy commented Jul 4, 2016

@Killyana: as it is working right now, the area "Chapter I" (57673) is removed when you accept "A Cold Front Approaches". This makes the questgiver and other npcs vanish in the instant you accept the quest.

It should instead stay until you complete "A Cold Front Approaches, which is when the aura "Chapter II" is added and the nerubians/frostwyrm/cannons appear. Here's a video about it.

I have been unable to get this working with quest_end = 13070 and quest_end_status = 64 (rewarded). This should make the aura 57673 vanish when the quest 13070 is rewarded. Instead, it prevents the aura from ever being cast to player. An uneducated guess of mine would be that any quest_end_status value different than 1 (quest not taken) is ignored when the quest_start is set to 0. I'll try to dig deeper.

In the meanwhile, can you test this?

UPDATE `spell_area` SET `quest_end_status`=1, `quest_end`=13086 WHERE `spell`=57673 AND `area` IN (4504, 4501);

It's not an issue of spell requirements, because spell_area casts are triggered and ignore any requirement. So it doesn't work with .cast, but if you check with .aura you can see that the aura is correctly applied.

There's also an issue with abandoning quests. If you abandon a quest, all the spell_area auras are removed. But if you kill and revive yourself, they're applied correctly again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants