Halls_of_reflection.cpp question？

[w137000133]

I carefully read the source code written by _events.ScheduleEvent found that
1067th lines (EVENT_ESCAPE_22, 1000);
It should be _events.ScheduleEvent (EVENT_ESCAPE_23, 1000);
Otherwise the code will go into an infinite loop, isn't it?
Please forgive my English is the Chinese people

[Demonid]

That was what i reported, an infinite loop of spwans on the last part of the Heroic.

[w137000133]

22 infinite loop if not corrected. Will not jump into the 23

[FireEmerald]

Reference #10698 / [3.3.5] HoR: Lich King Escape Event Infinite Spawns

[joschiwald]

ScheduleEvent EVENT_ESCAPE_23 is handled in an other way

there is a bit more incorrect stuff

[RedSonja]

Mine works fine the only thing is the quest does not complete at end, but I think that it is something to do with the quest not the scripting for HoR.

[SnakeIceBr]

 case EVENT_ESCAPE_22:
                        if (Creature* lichking = me->GetCreature(*me, _lichkingGUID))
                        {
                            if (_icewall >= 2 && _icewall < 4)
                                lichking->AI()->DoCast(lichking, SPELL_SUMMON_LUMBERING_ABOMINATION);
                        }
                        if (_instance->GetData(DATA_TEAM_IN_INSTANCE) == HORDE)
                        {
                            me->AI()->DoCast(me, SPELL_SYLVANAS_DESTROY_ICE_WALL, false);
                            if (_isattackingwall)
                                _events.ScheduleEvent(EVENT_ESCAPE_22, 1000);
                        }
                        break;

Change it to:

 case EVENT_ESCAPE_22:
                        if (Creature* lichking = me->GetCreature(*me, _lichkingGUID))
                        {
                            if (_icewall >= 2 && _icewall < 4)
                                lichking->AI()->DoCast(lichking, SPELL_SUMMON_LUMBERING_ABOMINATION);
                        }
                       _events.ScheduleEvent(EVENT_ESCAPE_22h, 1000);
case EVENT_ESCAPE_22h:
                        if (_instance->GetData(DATA_TEAM_IN_INSTANCE) == HORDE)
                        {
                            me->AI()->DoCast(me, SPELL_SYLVANAS_DESTROY_ICE_WALL, false);
                            if (_isattackingwall)
                                _events.ScheduleEvent(EVENT_ESCAPE_22h, 1000);
                        }
                        break;

Dont forget to add the EVENT_ESCAPE_22h at the top of the file.

• SnakeIce

[SnakeIceBr]

To explain: EVENT_ESCAPE_22 was supposed to be about Sylvannas hitting the wall all the time. Have NO idea how that Lumbering Abomination summon end up there.

[joschiwald]

dd4404e#commitcomment-4237666