Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.3.4] Bug BACKTRACE #10846

Closed
rodrigoalv opened this issue Sep 16, 2013 · 5 comments
Closed

[4.3.4] Bug BACKTRACE #10846

rodrigoalv opened this issue Sep 16, 2013 · 5 comments
Assignees
@Vincent-Michael
Labels
Branch-4.3.4 Comp-Core Feedback-PatchFix

Comments

@rodrigoalv
Copy link

Hi:

REV: last
DB: last Trinity 4.3.4

Error BACKTRACE today

BACKTRACE #1.-

BACKTRACE

(gdb) bt
#0 0x0000000001080d10 in Player::GetBGTeam (this=0x0)

at /home/repos/Trinity/src/server/game/Entities/Player/Player.cpp:22604

#1 0x0000000000e62656 in BattlegroundMgr::BuildPvpLogDataPacket (

this=0x7fffcdcc2008, data=0x7fffb73fea60, bg=0x7fff5adcfa00)
at /home/repos/Trinity/src/server/game/Battlegrounds/BattlegroundMgr.cpp:404

#2 0x0000000001203a0c in WorldSession::HandlePVPLogDataOpcode (

this=0x7fffb2c51b00)
at /home/repos/Trinity/src/server/game/Handlers/BattleGroundHandler.cpp:373

#3 0x00000000012c3260 in WorldSession::Update (this=0x7fffb2c51b00,

diff=3738, updater=...)
at /home/repos/Trinity/src/server/game/Server/WorldSession.cpp:349

#4 0x000000000138e6af in World::UpdateSessions (this=0x7ffff223d208,

diff=3738)
at /home/repos/Trinity/src/server/game/World/World.cpp:2682

#5 0x000000000138c323 in World::Update (this=0x7ffff223d208, diff=3738)

at /home/repos/Trinity/src/server/game/World/World.cpp:2033

#6 0x0000000000e4281f in WorldRunnable::run (this=0x7fffb8b708e0)

at /home/repos/Trinity/src/server/worldserver/WorldThread/WorldRunnable.cpp:60

---Type to continue, or q to quit---shell ech

Error BACKTRACE #2

BACKTRACE

(gdb) bt
#0 0x00000000015119e2 in Trinity::Assert (

file=0x1c2d970 "/home/repos/Trinity/src/server/shared/Utilities/Util.cpp", line=43, function=0x1c2dd60 "frand",
message=0x1c2d961 "max >= min")
at /home/repos/Trinity/src/server/shared/Debugging/Errors.cpp:32

#1 0x000000000151da36 in frand (min=0.383160174, max=-0.383160174)

at /home/repos/Trinity/src/server/shared/Utilities/Util.cpp:43

#2 0x000000000133b3de in SpellEffectInfo::CalcValue (this=0x7fffe7c69de8,

caster=0x7fff5e11f000, bp=0x7fff9b946260, target=0x0)
at /home/repos/Trinity/src/server/game/Spells/SpellInfo.cpp:456

#3 0x0000000000fa559d in Unit::CalculateSpellDamage (this=0x7fff5e11f000,

target=0x0, spellProto=0x7fffe7c69c00, effect_index=0 '\000',
basePoints=0x7fff9b946260)
at /home/repos/Trinity/src/server/game/Entities/Unit/Unit.cpp:10968

#4 0x0000000001360cdc in Spell::CalculateDamage (this=0x7fff5ee47300,

i=0 '\000', target=0x0)
at /home/repos/Trinity/src/server/game/Spells/Spell.h:409

#5 0x0000000001355951 in Spell::HandleEffects (this=0x7fff5ee47300,

pUnitTarget=0x0, pItemTarget=0x0, pGOTarget=0x0, i=0,
mode=SPELL_EFFECT_HANDLE_LAUNCH)

---Type to continue, or q to quit---shell echo -e "\nBACKTRACE FULL\n"
at /home/repos/Trinity/src/server/game/Spells/Spell.cpp:4772
#6 0x000000000135d360 in Spell::HandleLaunchPhase (this=0x7fff5ee47300)

at /home/repos/Trinity/src/server/game/Spells/Spell.cpp:6746

#7 0x000000000135051d in Spell::cast (this=0x7fff5ee47300, skipCheck=true)

at /home/repos/Trinity/src/server/game/Spells/Spell.cpp:3311

#8 0x0000000001351533 in Spell::update (this=0x7fff5ee47300, difftime=1782)

at /home/repos/Trinity/src/server/game/Spells/Spell.cpp:3607

#9 0x000000000135d0a1 in SpellEvent::Execute (this=0x7fff6b5520d0,

e_time=5399, p_time=1782)
at /home/repos/Trinity/src/server/game/Spells/Spell.cpp:6633

#10 0x000000000152202f in EventProcessor::Update (this=0x7fff5e11f298,

p_time=1782)
at /home/repos/Trinity/src/server/shared/Utilities/EventProcessor.cpp:47

#11 0x0000000000f7e541 in Unit::Update (this=0x7fff5e11f000, p_time=1782)

at /home/repos/Trinity/src/server/game/Entities/Unit/Unit.cpp:318

#12 0x00000000010cb944 in Creature::Update (this=0x7fff5e11f000, diff=1782)

at /home/repos/Trinity/src/server/game/Entities/Creature/Creature.cpp:519

#13 0x000000000144cf86 in Pet::Update (this=0x7fff5e11f000, diff=1782)

at /home/repos/Trinity/src/server/game/Entities/Pet/Pet.cpp:612

---Type to continue, or q to quit---bt full
#14 0x0000000001236207 in Trinity::ObjectUpdater::Visit (this=0x7fffbfbfed30,

m=...)
at /home/repos/Trinity/src/server/game/Grids/Notifiers/GridNotifiersImpl.h:45

#15 0x0000000001240fc6 in void VisitorHelper<Trinity::ObjectUpdater, Creature>(Trinity::ObjectUpdater&, ContainerMapList&) ()
#16 0x0000000001240959 in VisitorHelper<Trinity::ObjectUpdater, Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > (v=..., c=...)

at /home/repos/Trinity/src/server/shared/Dynamic/TypeContainerVisitor.h:70

#17 0x00000000012400a8 in VisitorHelper<Trinity::ObjectUpdater, Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > > (v=...,

c=...)
at /home/repos/Trinity/src/server/shared/Dynamic/TypeContainerVisitor.h:71

#18 0x000000000123f943 in VisitorHelper<Trinity::ObjectUpdater, TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > > >

(v=..., c=...)
at /home/repos/Trinity/src/server/shared/Dynamic/TypeContainerVisitor.h:94

#19 0x000000000123f184 in TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > > > >::Visit (this=0x7fffbfbfed10, c=...)

---Type to continue, or q to quit---shell echo -e "\nTHREADS\n"
at /home/repos/Trinity/src/server/shared/Dynamic/TypeContainerVisitor.h:105
#20 0x000000000123dc0a in Grid<Player, TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > >, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeList<AreaTrigger, TypeNull> > > > > >::VisitTrinity::ObjectUpdater (this=0x7fff5e600b98,

visitor=...)
at /home/repos/Trinity/src/server/game/Grids/Grid.h:98

#21 0x000000000123bef1 in NGrid<8u, Player, TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > >, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeList<AreaTrigger, TypeNull> > > > > >::VisitGrid<Trinity::ObjectUpdater, TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > > > (

this=0x7fff5e5fc000, x=5, y=3, visitor=...)
at /home/repos/Trinity/src/server/game/Grids/NGrid.h:157

#22 0x000000000123869e in Map::Visit<Trinity::ObjectUpdater, TypeMapContainer<TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > > > > (this=0x7fffda2eb000, cell=..., visitor=...)

at /home/repos/Trinity/src/server/game/Maps/Map.h:695

#23 0x000000000122c1bc in Map::VisitNearbyCellsOf (this=0x7fffda2eb000,

obj=0x7fff49847000, gridVisitor=..., worldVisitor=...)
at /home/repos/Trinity/src/server/game/Maps/Map.cpp:512

#24 0x000000000122c492 in Map::Update (this=0x7fffda2eb000, t_diff=1782)

---Type to continue, or q to quit---info threads
at /home/repos/Trinity/src/server/game/Maps/Map.cpp:553
#25 0x000000000148a09e in MapUpdateRequest::call (this=0x7fff60cd7fa0)

at /home/repos/Trinity/src/server/game/Maps/MapUpdater.cpp:54

#26 0x000000000151d065 in DelayExecutor::svc (this=0x7ffff4905340)

at /home/repos/Trinity/src/server/shared/Threading/DelayExecutor.cpp:52

#27 0x00007ffff76f0d77 in ACE_Task_Base::svc_run (args=)

at ../../ace/Task.cpp:271

#28 0x00007ffff76f2122 in ACE_Thread_Adapter::invoke_i (

this=<value optimized out>) at ../../ace/Thread_Adapter.cpp:161

#29 0x00007ffff76f21a1 in ACE_Thread_Adapter::invoke (this=0x7fffcbceaba0)

at ../../ace/Thread_Adapter.cpp:96

#30 0x00007ffff67338ca in start_thread () from /lib/libpthread.so.0
#31 0x00007ffff5ceeb6d in clone () from /lib/libc.so.6
#32 0x0000000000000000 in ?? ()

(gdb) shell echo -e "\nTHREADS BACKTRACE\n"

THREADS BACKTRACE
@zorix
Copy link
Contributor

zorix commented Sep 16, 2013

Fix first crash: (prevent sending data about non existing players in world)
http://www.trinitycore.org/f/pastebin/7hc8dhl44em/
it will fix error reading packet on client side when for any player "if (!bg->IsPlayerInBattleground(itr->first))" give true

Fix second crash:
http://www.trinitycore.org/f/pastebin/d8440b16ps7/

@rodrigoalv
Copy link
Author

@zorix thank you, will post more crashes with backtrace as I can test with many player now.

Greetings

@Aokromes
Copy link
Member

Don't post multiple bugs on a single ticket.

@rodrigoalv
Copy link
Author

ok Sorry,:D and ty soo much :D

@rodrigoalv
Copy link
Author

@Aokromes the fix of @zorix is work fine, i tested and the Bug BACKTRACE is solved.

@zorix zorix mentioned this issue Sep 20, 2013
Merged
@ghost ghost assigned Vincent-Michael Sep 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vincent-Michael Vincent-Michael

Labels
Branch-4.3.4 Comp-Core Feedback-PatchFix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Aokromes @Vincent-Michael @zorix @rodrigoalv