[Gunship battle] Kor'kron Battle-mage

[Pirricli]

This NPC freezes the cannons but when a DK throws them the spell Death grip it doesn't freeze anymore the cannons, so you don't need to jump to other ship to pass the battle.

commit 98a9a08

[ghost]

confirm

[snehurka324]

Confirm b0d0bed for example: hunters trap, death grip

[Demonid]

Confirmed on 394ac74

[Ryosan23]

Confirmed.

Once you cut the spell (Below Zero), npc do nothing for the rest of the battle, and of course, not appear more mages.

I've tried with mechanic_immune_mask_but not possitive results.

Proof with death grip: http://youtu.be/UBS0BTitfFc

[Golrag]

Try this

diff --git a/src/server/game/Spells/Spell.cpp b/src/server/game/Spells/Spell.cpp
index 7e15057..01fb3dc 100644
--- a/src/server/game/Spells/Spell.cpp
+++ b/src/server/game/Spells/Spell.cpp
@@ -2263,6 +2263,8 @@ void Spell::DoAllEffectOnTarget(TargetInfo* target)
                 m_caster->ToCreature()->LowerPlayerDamageReq(target->damage);
         }
     }
+    else if (missInfo == SPELL_MISS_IMMUNE)
+        return;

     if (spellHitTarget)
     {

[Demonid]

Whats the code for adding a Diff in a comment?

[Aokromes]

```diff

[Demonid]

@Aokromes Thanks ^^

@Golrag Add this too:

diff --git a/src/server/scripts/Northrend/IcecrownCitadel/boss_icecrown_gunship_battle.cpp b/src/server/scripts/Northrend/IcecrownCitadel/boss_icecrown_gunship_battle.cpp
index c0c909e..3a5abc3 100644
--- a/src/server/scripts/Northrend/IcecrownCitadel/boss_icecrown_gunship_battle.cpp
+++ b/src/server/scripts/Northrend/IcecrownCitadel/boss_icecrown_gunship_battle.cpp
@@ -1719,6 +1719,8 @@ class npc_gunship_mage : public CreatureScript
             npc_gunship_mageAI(Creature* creature) : gunship_npc_AI(creature)
             {
                 me->SetReactState(REACT_PASSIVE);
+                me->ApplySpellImmune(0, IMMUNITY_EFFECT, SPELL_EFFECT_KNOCK_BACK, true);
+                me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_GRIP, true);
             }

             void EnterEvadeMode() override

[Golrag]

Just tested my diff with death grip and it works.
@Demonid those are already in mechanic_immune_mask, so I don't think we will need it

[Demonid]

@Golrag On my server i could use spells like Thunderstorm to move the mage while running to the cast point, then again i didn't try to add the immunities by DB.

[Golrag]

Oh... there is no immune mask for knockback in the database D:

[Demonid]

@Golrag I don't know if this just happens to me but even with both of our codes, the mages are still getting bug.

If you hit/damage the mages who are casting the portal before the first mage is summoned, once it reaches it's destination point it will not freeze the cannons.

[Ryosan23]

There are two differents problems.

The first one, was to cut casting of Below Zero from mage,and it's solved with previous comments.

The other one happens when you hit any npc that cames from portal before they 'arrive' to their place. This is still wrong.

[Rushor]

so make the npcs immune to player until they reach the given place could be a solution? Do player must be able to hit them on their way?

[Demonid]

Btw, using @Golrag code bugged the spell Fear Ward http://www.wowhead.com/spell=6346 on my server, it doesn't remove after absorbing a Fear type spell.

[ghost]

On my server sometimes freeze only one cannon, the 2nd cannon says evade.

[Ryosan23]

¿Like this?

else if ((missInfo == SPELL_MISS_IMMUNE) && ((unit->GetGUID()== 37116) || (unit->GetGUID() == 37117)))
return;

[ghost]

I think u want unit->GetEntry()

[Golrag]

--- a/src/server/scripts/Northrend/IcecrownCitadel/boss_icecrown_gunship_battle.cpp
+++ b/src/server/scripts/Northrend/IcecrownCitadel/boss_icecrown_gunship_battle.cpp
@@ -1721,6 +1721,7 @@ class npc_gunship_mage : public CreatureScript
             npc_gunship_mageAI(Creature* creature) : gunship_npc_AI(creature)
             {
                 me->SetReactState(REACT_PASSIVE);
+                me->SetInCombatWithZone();
                 me->ApplySpellImmune(0, IMMUNITY_EFFECT, SPELL_EFFECT_KNOCK_BACK, true);
             }

This did it for me, but if everyone is dead or if you try it alone and you activate gm-mode, then it is interrupted again

[Rushor]

@Golrag: Your fix will solve the problem that the battlemage interrupt it' s cast if you use deathgrip on him right?

Would it be pssible to put that one:

else if ((missInfo == SPELL_MISS_IMMUNE) && ((unit->GetEntry()== 37116) || (unit->GetEntry() == 37117)))
return;

in the script of the battlemages in another way?

The fix in spell.cpp seems to be a little bit hacky.

[Golrag]

Yup it fixes it. I didn't make changes in spell.cpp for this ^^

[Rushor]

and btw, we have the same problem with deathgrip with the boss urom in occulus. if a dk uses that spell instant on urom, he will not teleport hisself to another platform.

[Golrag]

He doesn't have mechanic_immune_mask :/

UPDATE creature_template SET mechanic_immune_mask=32 WHERE entry=27655;

Should fix it for grip ^^

[Rushor]

nope he will be immune against the grip, if he is in combat an he starts casting the teleport, he will be immune aginst it.
BUT: if you are ooc and the boss is also ooc and if you use at that moment the deathgrip on him, the boss will fail it's teleport spell.
How to reproduce: use deathgrip at maxrange in front of urom.

I tried:
UPDATE creature_template SET mechanic_immune_mask=32 WHERE entry=27655;
and
me->SetInCombatWithZone();
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_GRIP, true);

-> Everything does not work.

[Tangol]

@Mage-Lord Urom it should be:

UPDATE `creature_template` SET `mechanic_immune_mask`=32 WHERE `entry` IN (27655,31560);

For both his modes.

[Rushor]

nevertheless the problem will occure if you use the deathgrip ooc on urom. For the battelmages it seems to works, because they are always in combat.

[ghost]

the second code of @Golrag will fix the Kor'kron Battle-mage bug ?

[D4R4]

The commit fixed the issue for almost all spells but this spells can still mess up the MageAI and turn it into a vegtable:
Feral Charge - Cat

[Rushor]

could you try to change the interrupt flags of the 'below-zero' spell to interrupt none?

[ghost]

confirm, still persist

[ghost]

Changing interrupt flags of below-zero to none doesn't fix this, been there

[Rushor]

channelinterruptflags maybe also set to 0

[D4R4]

Does the mage only get bugged with Feral Charge - Cat spell or are there any others ways to bug it?
so far I only know of the charge, that's why I looked at the Charge spell attributes to see if something sticks out instead of CreatureAI or Below Zero spell, no luck so far :|

[Rushor]

and btw, we should open a new ticket for this ^^

[Mack36]

Maybe just give 'em UNIT_FLAG_NOT_SELECTABLE flag while they're moving?

[ghost]

Maybe just give 'em UNIT_FLAG_NOT_SELECTABLE flag while they're moving?

Haaaaaaaaaack

[Mack36]

Haaaaaaaaaack

Yep)
Also Arcane Torrent http://www.wowhead.com/spell=28730 and War Stomp http://www.wowhead.com/spell=20549 casted on spawned npcs (Gunship Battle npcs like Kor'kron Battle Mage) while they're moving, turn them into vegetables just staying there and doing nothing. Though they got immunities.

[lellonicole]

@Shauren The battle mage casting interrupt is still bugged. Any ideas?

[lellonicole]

Try this:

case SLOT_FREEZE_MAGE:
if (Player* player = me->SelectNearestPlayer(50.0f))
{
me->SetInCombatWithZone();
me->AddThreat(player, 1.0f);
DoCastAOE(SPELL_BELOW_ZERO);
}
break;

[Keader]

And please... stop comment in closed issue...
use #14912