Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crash] .cast 54438 #14953

Closed
jackpoz opened this issue Jun 25, 2015 · 2 comments
Closed

[crash] .cast 54438 #14953

jackpoz opened this issue Jun 25, 2015 · 2 comments
Assignees
@MitchesD
Labels
Branch-3.3.5a HasBacktrace Sub-Spells

Comments

@jackpoz
Copy link
Member

jackpoz commented Jun 25, 2015

.cast 54438 is causing a crash on e34f74d Win x64 , no custom patches

Debug crash log at https://gist.github.com/jackpoz/d0ec74ff7b92d6b86278
Probably related to #14860
@mik1893
Copy link
Contributor

mik1893 commented Jun 25, 2015

sorry, did you try it from .cast, so not in the instance, isnt it?
in the istance this is working fine (unless i'm losing something i did on my core, code is the same)
Didn't try .cast, will try soon
Ok, it's just a missing if (target should be a creature, casting it on yourself will actually cause the crash as i didnt check target->ToCreature()).
Fix incoming

@jackpoz
Copy link
Member Author

jackpoz commented Jun 25, 2015

On the PR someone pointed out that the ToCreature() check is unneeded if the object is a Unit, you can get the threatmanager object from Unit too

mik1893 added a commit that referenced this issue Jun 25, 2015
@mik1893
Scripts/VioletHold: Fix codestyle and unwanted crash in Violet/Hold
49809bd 
closes #14952 and #14953
@TrinityCoreBot TrinityCoreBot mentioned this issue Jun 25, 2015
Closed
2 tasks
@mik1893 mik1893 closed this as completed Jun 25, 2015
@TrinityCoreBot TrinityCoreBot mentioned this issue Jul 12, 2015
Closed
2 tasks
DDuarte added a commit that referenced this issue Jul 12, 2015
@DDuarte
Scripts/VioletHold: cherry-pick multiple commits from 3.3.5
9aa9106 
---

Scripts/VioletHold: picked some things from pull request #11399 (thx MitchedD for initial work)

(cherry picked from commit 34a721b)

by joschiwald

---

Core/Scripts: Rework Violet Hold bosses adding missing spells/mechanics:
- Cyanigosa, Arcane Vacuum
- Ichoron, globules mechanic
- Moragg, optic link visuals
- Lavanthor, minor changes
- Zuramat, correctly implement void sentries
- Erekem, implement Windfury and correct management of Erekem Guards
- Script for the pre-event
Thx @ManuFe

(cherry picked from commit 0bb7f89)

Conflicts:
	src/server/scripts/Northrend/VioletHold/boss_erekem.cpp

by mik1893

---

Rename 2015_06_08_01_world.sql to 2015_06_25_00_world.sql
(cherry picked from commit 8176902)

by MitchesD

---

Scripts/VioletHold: fixed non-pch build and codestyle

(cherry picked from commit e34f74d)

by MitchesD

---

Scripts/VioletHold: Fix codestyle and unwanted crash in Violet/Hold
closes #14952 and #14953

(cherry picked from commit 49809bd)

by mik1893

---

Scripts/VioletHold: fix a crash during Ichoron encounter
Closes #14962

(cherry picked from commit 7c01638)

by mik1893

---

Core/Misc: Fix build warnings

(cherry picked from commit 5568166)

Conflicts:
	src/server/authserver/Main.cpp

by jackpoz
@namreeb namreeb mentioned this issue Jun 23, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MitchesD MitchesD

Labels
Branch-3.3.5a HasBacktrace Sub-Spells
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jackpoz @mik1893 @MitchesD