[3.3.5] Spells Mortar and Fire Cannon hitting friends

[Keader]

spell 62358 = [Fire Cannon]
spell 62634 = [Mortar]

Spells used by Salvaged Demolisher and Salvaged Siege Engine (weapons)
Both spells are giving damage in friendly units

Test on rev fae8269

Related: 6a15216

Suggested correction:

UPDATE `conditions` SET `SourceGroup`=2 WHERE `SourceTypeOrReferenceId`=13 and`SourceGroup`=3 and`SourceEntry` IN (65044,65045);

There's already entry for those spells in DB, but for an inexistent effect.
In current TDB, is for EFFECT_2, and should be for EFFECT_1

[joschiwald]

Ulduar vehicle conditions are total wrong

[Keader]

The first floor of Ulduar as a whole seems wrong hehe

[jackpoz]

There's already entry for those spells in DB, but for an inexistent effect.
In current TDB, is for EFFECT_2, and should be for EFFECT_1

Is there a db error on load about this case ? otherwise it should be added

[Keader]

When loading does not give errors Jack

[sirikfoll]

If shouldn't hit the vehicles, this may solve it:

DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId`=13 AND `SourceEntry` IN (65044,65045) AND `ConditionValue2` IN (33060,33109,34045,33062);

[joschiwald]

-- Removed useless conditions
DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId`=13 AND `SourceEntry` IN (62290,62307,62357,62489,62635);
-- Adjusted incorrect conditions
DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId`=13 AND `SourceEntry` IN (62363,65044,65045);
INSERT INTO `conditions` (`SourceTypeOrReferenceId`,`SourceGroup`,`SourceEntry`,`SourceId`,`ElseGroup`,`ConditionTypeOrReference`,`ConditionTarget`,`ConditionValue1`,`ConditionValue2`,`ConditionValue3`,`NegativeCondition` ,`ErrorTextId`,`ScriptName`,`Comment`) VALUES
(13,2,62363,0,0,31,0,3,33214,0,0,0,'','Flame Leviathan - Anti-Air Rocket'),
(13,1,65044,0,0,32,0,0x18, 0,0,0,0,'','Flame Leviathan - Flames'), -- should hit everything
(13,2,65044,0,0,31,0,3,33090,0,0,0,'','Flame Leviathan - Flames'),
(13,1,65045,0,0,32,0,0x18, 0,0,0,0,'','Flame Leviathan - Flames'), -- should hit everything
(13,2,65045,0,0,31,0,3,33090,0,0,0,'','Flame Leviathan - Flames');

[Keader]

joschiwald fix is better and work 👍

[Keader]

Related: #4078

[Killyana]

This can be pushed?

[joschiwald]

yes i guess