Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[335] Mark of the Wild (Rank 2+) Is Cancelled By Scrolls #17912

Open
MrSmite opened this issue Sep 7, 2016 · 10 comments
Open

[335] Mark of the Wild (Rank 2+) Is Cancelled By Scrolls #17912

MrSmite opened this issue Sep 7, 2016 · 10 comments

Comments

@MrSmite
Copy link
Contributor

MrSmite commented Sep 7, 2016

Description: Mark of the Wild (Ranks 2+) are cancelled by scrolls

Current behaviour: If you have Mark of the Wild (Rank 2) active and use any scroll it will cancel Mark, even though Mark also enhances stats unrelated to the scroll.

Expected behaviour: The scroll, if stronger than Mark should replace the enhancement on only that specific stat while leaving Mark to enhance the remaining stats

Steps to reproduce the problem:

  1. Apply Mark of the Wild Rank 2 +2 all stats
  2. Apply Scroll of Intellect +3 INT

Since Mark (Rank 2) enhances all stats by +2 and the scroll enhances INT by +3, it should replace the +2 with +3 on the INT stat only and leave the +2 from Mark on STA, AGI, etc.

Instead it wipes them all away and won't let Mark reapply due to "a more powerful spell" error.

NOTE: This behavior is for all scrolls.

NOTE: This is similar to #12470 however in that report it mentioned Mark Rank 1 specifically which only modifies ARMOR. The link posted there re: stacking is not relevant to Mark Rank 2 or higher because they enhance ALL stats and there is no scroll that does that. Stacking penalty should only apply to the stat modified by the better scroll.

NOTE: I was not able to find any specific info about Mark stacking in regards to the WotLK generation so this report may be "wishful thinking".

Branch(es): 3.3.5

TC hash/commit: 2db9269

TDB version: TDB_full_world_335.61_2016_04_11.sql

Operating system: Win XP / Win 7

@Treeston
Copy link
Contributor

Treeston commented Sep 9, 2016

I don't think partially wiping spells is possible. I'm not sure which one would stick on retail, but I'm sure that only one would stick on the target (either mark or the scroll).

I suspect it might just be whichever was last cast.

@ghost
Copy link

ghost commented Sep 9, 2016

Would be nice to have some "evidence" or reference to what the actual behaviour was in 2009-2010.
@MrSmite : do you think you can dig up some old YouTube video or verifiable forum post about it?

@ariel-
Copy link
Contributor

ariel- commented Sep 10, 2016

Not wiping spells, but instead having both active while only receiving most significant stat increase instead of both, this is possible with the spell_group_stack_rules table.

It remains to check what was actual retail behaviour though

@MrSmite
Copy link
Contributor Author

MrSmite commented Sep 12, 2016

@tkrokli - I tried before even posting but unfortunately there isn't much available. There were a couple forum posts on battle.net but none of them were answered. As far as Youtube videos go, no dice.

There is this list that shows the Cata version of exclusive categories and Mark is not in the same category as scrolls. Don't know if that would be enough evidence to back port to 3.3.5.

Also, a nice spreadsheet (jpg) from an old Hunter forum I used to visit, petopia, specifically for raid buffs in Cata.

@MrSmite
Copy link
Contributor Author

MrSmite commented Oct 29, 2016

I don't think partially wiping spells is possible.

After giving this some more thought and considering the above comment, I wonder if it would be better to have the core consider Mark (Rank 2+) to be the "better spell" because it enhances more stats than the single-stat scroll (eg: The scroll is a +3 but Mark 2 is essentially a +10) and throw the error when the player attempts to use the scroll.

If they really want the +3 INT (or better) then they can cancel the Mark buff and get it again later.

@MrSmite
Copy link
Contributor Author

MrSmite commented Nov 11, 2016

Further consideration:

Scrolls stack with Blessing of Kings which is +10% to all stats. This is the behavior I would expect from MotW.

@Aokromes
Copy link
Member

this issue is still valid?

@MrSmite
Copy link
Contributor Author

MrSmite commented Apr 4, 2021

this issue is still valid?

Sorry, I don't have a new eough core to test.

@ghost
Copy link

ghost commented Apr 4, 2021

TrinityCore rev. 39bd263 2021-04-03 21:27:06 +0200 (3.3.5 branch) (Win64, Release, Static)

Confirmed, item 955 — Scroll of Intellect (+3 int) — cancels the buff Mark of the Wild, Rank 2.

I don't know if this still needs to be kept as an open issue, but if the TC behaviour is different from retail, I presume it will be.

@MrSmite
Copy link
Contributor Author

MrSmite commented Apr 15, 2021

After this many years, I've learned to live with it. It isn't entirely gamebreaking so it may not be worth the time to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants