New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.3.5] Achievements: progress not given #19064
Comments
I vote 7c7b877 |
@Aokromes don't have that commit in source and the same screenshot green items on character added in past so it works. I think it's 9b44ed9 or something in that time, items shows green and grant to achievement are added in that time. Sorry for Eng. |
9b44ed9 broke it, by inverting miscvalues passed in ACHIEVEMENT_CRITERIA_TYPE_EQUIP_EPIC_ITEM (which superior and epic achievements use) |
funjoker
referenced
this issue
in The-Cataclysm-Preservation-Project/TrinityCore
Jan 28, 2022
…EQUIPPED_ITEM item Closes #19064 (cherry picked from commit 70c4a37)
Warpten
pushed a commit
to Warpten/TrinityCore
that referenced
this issue
Feb 5, 2022
…EQUIPPED_ITEM item Closes TrinityCore#19064 (cherry picked from commit 70c4a37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Seems like recent changes to achievement system broke achievs like
http://www.wowhead.com/achievement=557/superior
Steps to reproduce the problem:
Branch(es): 3.3.5
TC rev. hash/commit:
c6060dd
The text was updated successfully, but these errors were encountered: