Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3.5] Achievements: progress not given #19064

Closed
ccrs opened this issue Feb 7, 2017 · 4 comments
Closed

[3.3.5] Achievements: progress not given #19064

ccrs opened this issue Feb 7, 2017 · 4 comments

Comments

@ccrs
Copy link
Member

ccrs commented Feb 7, 2017

Seems like recent changes to achievement system broke achievs like
http://www.wowhead.com/achievement=557/superior

Steps to reproduce the problem:

  1. create a character
  2. give items

Branch(es): 3.3.5

TC rev. hash/commit:
c6060dd

@Aokromes
Copy link
Member

Aokromes commented Feb 7, 2017

I vote 7c7b877

@Feedcode
Copy link

Feedcode commented Feb 7, 2017

@ccrs Can confirm, giving items with needed itemlevel does not grant achievements.
@Aokromes I did revert the changes from commit 7c7b877, still the same, no achievement. I guess the error is in another commit.

@Viste
Copy link

Viste commented Feb 8, 2017

@Aokromes don't have that commit in source and the same screenshot green items on character added in past so it works. I think it's 9b44ed9 or something in that time, items shows green and grant to achievement are added in that time. Sorry for Eng.

@ariel-
Copy link
Contributor

ariel- commented Apr 8, 2017

9b44ed9 broke it, by inverting miscvalues passed in ACHIEVEMENT_CRITERIA_TYPE_EQUIP_EPIC_ITEM (which superior and epic achievements use)

ariel- added a commit that referenced this issue Apr 8, 2017
Shauren pushed a commit that referenced this issue May 1, 2020
…EQUIPPED_ITEM item

Closes #19064

(cherry picked from commit 70c4a37)
funjoker referenced this issue in The-Cataclysm-Preservation-Project/TrinityCore Jan 28, 2022
…EQUIPPED_ITEM item

Closes #19064

(cherry picked from commit 70c4a37)
Warpten pushed a commit to Warpten/TrinityCore that referenced this issue Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants