Quest/Spells: The Eye of Acherus (51852) buff is not removed

[dewmguy]

Description:
The spell/effect "Controlling the Eye of Acherus" remains on your character and must be manually dispelled after you turn in the quest The Might of the Scourge (ID 12657).

The spell/effect should be automatically removed upon completion of the quest.

Branch(es):
3.3.5

TC rev. hash/commit:
c6060dd 2017-02-05 21:10:15 -0300 (3.3.5 branch) (Win64, Release, Static)

TDB version:
335.62

Operating system:
Windows 10 Server & Client

[ghost]

How is this issue (or "The Might of the Scourge") related to [BUG]visual bug about drink and food ?

[dewmguy]

I don't understand what you mean by

[BUG]visual bug about drink and food

[Tooa]

You referred to another issue called [BUG]visual bug about drink and food in your Current behavior description by mentioning #12567. See your initial post.

[dewmguy]

That's the quest ID. It says "Quest 12567". I'm sorry if I did not follow correct protocol with formatting my issue submission.

[ghost]

OK, fair enough. As long as you know that using the hash tag and a number between 1 and 19140 (currently highest number used in this repository, but increasing continuously for each new issue or PR), it will link to and refer the issue your comment is in in the other issue or pull request. Because of this GitHub feature, it is better to use plain numbers or links to wowhead or openwow.com pages to provide easy access to information about the quest ID, spell ID, NPC ID, item ID or other ID you refer to.

[dewmguy]

Good to know. Any word on a fix for the issue?

[ghost]

About the spell/buff you refer to, "Controlling the eye of Acherus", it would be practical if you had referred to the actual spell and confirmed in-game what the buff spell ID is, so it would be quicker to look it up.

At first, I thought you had confused [Controlling the eye of Acherus] with the buff you are supposed to gain from quest 12657 ((notice quest ID 12567 = http://www.wowhead.com/quest=12567/blessing-of-zimabwa)), namely [Dominion Over Acherus] (http://www.wowhead.com/spell=51721/dominion-over-acherus).

After a bit of manual searching, I located spell ID 51852 [The Eye of Acherus] which has the flavor text "Controlling the Eye of Acherus". I guess this is related to the previous quest [Death Comes From On High] (http://www.wowhead.com/quest=12641/death-comes-from-on-high).

My first thought on this is that it could have something to do with aura handling and that the aura is not removed upon quest completion, but I don't know where it is handled yet. Maybe it is in some script, but I have not had time to look it up yet. If others have got time to look up where this is handled, it would be helpful and save some time in further troubleshooting. Mind you, this is cosmetic and not a big issue.

[dewmguy]

Yeah, I'm just flying by the seat of my pants here. I expect I'll be learning more about how to efficiently look up spell IDs and things in the near future. But thankfully someone like you is here. In the mean time, I will continue to provide as much information as I know how to access.

[MrSmite]

My first thought on this is that it could have something to do with aura handling and that the aura is not removed upon quest completion, but I don't know where it is handled yet.

This might help:

3.3.5 spell_quest.cpp#L2193

        class spell_q12641_recall_eye_of_acherus_SpellScript : public SpellScript
        {
            PrepareSpellScript(spell_q12641_recall_eye_of_acherus_SpellScript);

            void HandleDummy(SpellEffIndex /*effIndex*/)
            {
                if (Player* player = GetCaster()->GetCharmerOrOwner()->ToPlayer())
                {
                    player->StopCastingCharm();
                    player->StopCastingBindSight();
                    player->RemoveAura(THE_EYE_OF_ACHERUS);
                }
            }

Master spell_quest.cpp#L2194

        class spell_q12641_recall_eye_of_acherus_SpellScript : public SpellScript
        {
            PrepareSpellScript(spell_q12641_recall_eye_of_acherus_SpellScript);

            void HandleDummy(SpellEffIndex /*effIndex*/)
            {
                if (Player* player = GetCaster()->GetCharmerOrOwner()->ToPlayer())
                {
                    player->StopCastingCharm();
                    player->StopCastingBindSight();
                    player->RemoveAura(THE_EYE_OF_ACHERUS);
                }
            }

NOTE: In both branches, THE_EYE_OF_ACHERUS is defined in spell_quest.cpp as:

enum Recall_Eye_of_Acherus
{
    THE_EYE_OF_ACHERUS = 51852
};

Then there's this code as well:

3.3.5 SpellMgr.cpp#L3029

            case 51852: // The Eye of Acherus (no spawn in phase 2 in db)
                spellInfo->Effects[EFFECT_0].MiscValue |= 1;
                break;

Master SpellMgr.cpp#L3114

            case 51852: // The Eye of Acherus (no spawn in phase 2 in db)
                const_cast<SpellEffectInfo*>(spellInfo->GetEffect(EFFECT_0))->MiscValue |= 1;
                break;

[ghost]

Thanks for the code and links, good references. The Death Knight starter area is almost the same in both branches, but I am wondering if something has changed in the client communication or if there are other outside factors interfering in the quest, like spell errors. I should probably take a look at the hundreds of Server.log spell error lines and see if I can locate anything related to this spell.

---

Sorry, my bad, I was thinking too much about some of the master branch issues I have browsed recently and my mind was set on that branch when I wrote the comment above. I guess this needs standard 3.3.5 troubleshooting, because there is not as much in the error logs in 3.3.5 as in master (although there are some SmartAI errors in the 3.3.5 logs which might be worth looking into). I'll play the starter bit on 3.3.5 and see what I can find.

[Aokromes]

#18362