-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[335] Vmaps latests changes and Wintergrasp #20028
Comments
@Treeston can you take a look here? |
No idea - I have no clue how WG code works, and other places that use the same core logic work fine (EotS capture points). |
I'm not sure, but in Wintergrasp the phasemask changes, then can be possible worldobjects are in different phase with this change? |
wintergrasp needs all spawns moved into db to work properly. |
Dynamic spawns need to be implemented first, then move everything to db.. |
@Aokromes I think this not related with this I'm saying the worldobjects with this: f6c8497#diff-29afb15ead2a8204cac07d94f074f260R2561 Then, in Wintergrasp, the workshops zones are differents phases and change with defender team I think And in EotS or Hellfire outdoor capture point are in phasemask 1 But....I don't know if is true this or not xD |
Hellfire outdoor capture points seems doesn't work |
TrinityCore rev. a59ebb3 2017-07-18 22:05:30 +0200 (3.3.5 branch) (Win64, Release, Static) Confirmed, Hellfire Fortifications can't be captured, the PvP progress bar does not show up at all. When did this change? I seem to remember that these objectives worked half a year ago. |
I think is this commit: f6c8497 I will try to revert and test ASAP |
But I remember how many months ago I did not have a problem! It is strange 😃 |
Reverting this: f6c8497 Wintergrasp Capture Points and vehicle count works Now I will try to revert: a2c123b |
And confirm, Reverting this: a2c123b |
For vehicle count, seems like ZoneScript is null so |
try those two changes diff --git a/src/server/game/Entities/Creature/Creature.cpp b/src/server/game/Entities/Creature/Creature.cpp
index b11a5a8018..8dbe5be504 100644
--- a/src/server/game/Entities/Creature/Creature.cpp
+++ b/src/server/game/Entities/Creature/Creature.cpp
@@ -963,6 +963,7 @@ bool Creature::Create(ObjectGuid::LowType guidlow, Map* map, uint32 phaseMask, u
//! Relocate before CreateFromProto, to initialize coords and allow
//! returning correct zone id for selecting OutdoorPvP/Battlefield script
Relocate(x, y, z, ang);
+ UpdatePositionData();
// Check if the position is valid before calling CreateFromProto(), otherwise we might add Auras to Creatures at
// invalid position, triggering a crash about Auras not removed in the destructor diff --git a/src/server/game/Entities/GameObject/GameObject.cpp b/src/server/game/Entities/GameObject/GameObject.cpp
index be0406be5b..6ae82ea3ce 100644
--- a/src/server/game/Entities/GameObject/GameObject.cpp
+++ b/src/server/game/Entities/GameObject/GameObject.cpp
@@ -254,6 +254,7 @@ bool GameObject::Create(ObjectGuid::LowType guidlow, uint32 name_id, Map* map, u
}
SetPhaseMask(phaseMask, false);
+ UpdatePositionData();
SetZoneScript();
if (m_zoneScript) |
With these changes the problem is solved? |
Yea, still some problems but not related to this issue like wrong faction shown for workshops. |
Ah, so area data wasn't accurate on the first tick? Good catch, @Golrag. |
Won't have time to create a PR today I think, maybe tomorrow :p |
It is, in map relocation handler. ( |
Yeah but it isn't when we call |
You should never be calling PS: Non-C++ devs blindly spamming thumbs up on shit they don't understand is truly helpful, keep it up. |
So a GetMap()->CreatureRelocation would be a better fix than what I wrote ? I'm on mobile & won't PR today :s |
No, your fix is perfectly fine - it notifies the creature that its zone data changed on create (that's what However, all later changes to create position will (should) eventually go through a |
…n initially creating them. Fixes some issues with PvP objectives not having the correct area ID set on initialization. Closes #20028.
I have a reply to this with some hopefully helpful information, but I am here looking for a fix, not presenting one. The zone captures in Wintergrasp are working, but the factions are backwards. Meaning, alliance captures the horde way, and horde captures the alliance way. I'm not sure how to fix this. Also, there are a couple walls missing in WG and if you spawn ones in their place, they do not show up on the map. I've been testing for hours, if there are specific questions I'll be sure to answer them. This is on a fresh compile with the latest TC updates. |
your report doesn't belong to vmaps. |
Description:
With latests changes of Vmaps, Wintergrasp have stranges bugs
d2a30fe
a409287
cfb0f9f
a2c123b
f6c8497
c357939
I think the causant is:
f6c8497
( I can't comment in the commit because is closed f6c8497#commitcomment-22449905 )
I revert the commits and extract Vmaps and works fine
Wintergrasp vehicles count don't work
Wintergrasp Capture Points in Workshop don't work
...
Branch(es): 3.3.5
TC rev. hash/commit: 445c5a0
TDB version: TDB335.63
Operating system: Debian
The text was updated successfully, but these errors were encountered: