Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Storm King's Vengeance #20974

Open
dewmguy opened this issue Nov 26, 2017 · 14 comments
Open

The Storm King's Vengeance #20974

dewmguy opened this issue Nov 26, 2017 · 14 comments

Comments

@dewmguy
Copy link

dewmguy commented Nov 26, 2017

Description:
http://www.wowhead.com/quest=12919/the-storm-kings-vengeance
http://www.wowhead.com/spell=55421/gymers-throw
http://www.wowhead.com/spell=55426/gymers-smash

Current behaviour:
Scourge damaged or killed by Gymer's Throw do not fulfill quest criteria. Only scourge killed exclusively with Gymer's Smash fulfill quest criteria.

Video: Grab then Throw
Video: Smash Only

Expected behaviour:
Any scourge NPC should fulfill quest criteria when killed by Gymer.

Branch(es): 3.3.5

TC rev. hash/commit: e85a481

TDB version: 335.63

Operating system: Windows 10

@Atis6
Copy link

Atis6 commented Jan 11, 2018

Try this:
https://pastebin.com/TFbv2aCe

@ghost
Copy link

ghost commented Jan 12, 2018

Unless you set a prolonged expire time for the pastebin document, consider posting the SQL here instead.
(I have changed some of the formatting to fit TC codestyle, like query grouping.)

-- Vargul Blighthound
SET @ENTRY := 29889;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,0,0,0,100,0,6000,10000,16000,23000,11,50047,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vargul Blighthound - In Combat - Cast 'Broken Bone' (Phase 1) (No Repeat)"),
(@ENTRY,0,1,0,0,0,100,0,2000,15000,26000,33000,11,50046,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vargul Blighthound - In Combat - Cast 'Gnaw Bone' (Phase 1) (No Repeat)"),
(@ENTRY,0,2,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

-- Vegard the Unforgiven
SET @ENTRY := 37893;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,0,54,0,100,512,0,0,0,0,80,3789300,2,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Just Summoned - Run Script"),
(@ENTRY,0,1,2,8,0,100,512,70792,0,0,0,37,0,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Spell Hit(Kill Vegard) - Die"),
(@ENTRY,0,2,0,61,0,100,512,0,0,0,0,41,5000,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Spell Hit(Kill Vegard) - Despawn"),
(@ENTRY,0,3,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

-- Vargul Deathwaker
SET @ENTRY := 29890;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,0,0,0,100,0,3000,13000,19000,26000,11,56038,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vargul Deathwaker - In Combat - Cast 'Plaguebolt' (Phase 1) (No Repeat)"),
(@ENTRY,0,1,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

-- Banshee Soulclaimer
SET @ENTRY := 29893;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,0,0,0,100,0,4000,7000,9000,12000,11,28993,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Banshee Soulclaimer - In Combat - Cast 'Banshee Wail' (Phase 1) (No Repeat)"),
(@ENTRY,0,1,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

-- Acolyte of Pain
SET @ENTRY := 29935;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

-- SCOURGE PROXY (PHASED)
SET @ENTRY := 29943;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

-- Vegard the Unforgiven
SET @ENTRY := 37976;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,1,54,0,100,512,0,0,0,0,11,7398,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Just Summoned - Cast Rebirth"),
(@ENTRY,0,1,0,61,0,100,512,0,0,0,0,1,0,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Just Summoned - Say Line 0"),
(@ENTRY,0,2,3,6,0,100,0,0,0,0,0,1,1,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Death - Say Line 1"),
(@ENTRY,0,3,4,61,0,100,512,0,0,0,0,45,2,2,0,0,0,0,19,38001,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Death - Say Line Set Data 2 2 on Light's Vengeance Bunny 2"),
(@ENTRY,0,4,0,61,0,100,512,0,0,0,0,45,1,1,0,0,0,0,20,201937,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Death - Say Line Set Data 1 1 on Light's Vengeance"),
(@ENTRY,0,5,0,9,0,100,0,0,10,20000,35000,11,70866,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Range - Cast Shadow Blast"),
(@ENTRY,0,6,0,2,0,100,0,0,30,15000,25000,11,70886,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Less than 30% HP - Cast Vegard's Thirst"),
(@ENTRY,0,7,0,0,0,100,0,3000,7000,25000,35000,11,71003,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - IC - Cast 'Vegard's Touch'"),
(@ENTRY,0,8,9,7,0,100,0,0,0,0,0,1,2,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Evade - Say Line 2"),
(@ENTRY,0,9,0,61,0,100,512,0,0,0,0,41,5000,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Evade - Despawn"),
(@ENTRY,0,10,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

-- Vargul Runelord
SET @ENTRY := 29891;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,0,0,0,100,0,3000,13000,19000,26000,11,56036,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vargul Runelord - In Combat - Cast 'Rune of Destruction' (Phase 1) (No Repeat)"),
(@ENTRY,0,10,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

-- Reanimated Corpse
SET @ENTRY := 29897;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

-- Vargul Doombringer
SET @ENTRY := 29887;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,0,0,0,100,0,2000,20000,30000,40000,1,1,5000,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vargul Doombringer - In Combat - Say Line 1 (Phase 1) (No Repeat)"),
(@ENTRY,0,1,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

-- Vargul Slayer
SET @ENTRY := 29892;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

-- Acolyte of Agony
SET @ENTRY := 29934;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

-- Vargul Plaguetalon
SET @ENTRY := 29894;
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry`=@ENTRY LIMIT 1;

DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(@ENTRY,0,0,0,0,0,100,0,3000,9000,14000,21000,11,55079,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vargul Plaguetalon - In Combat - Cast 'Swoop' (Phase 1) (No Repeat)"),
(@ENTRY,0,1,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"On Spellhit Explosion - Get Kill credit");

BTW, source_type = 0 is expected for all creature smart_scripts outside of SAI scripts (source_type = 9).

@Atis6
Copy link

Atis6 commented Jan 12, 2018

Thanks:)

@ghost
Copy link

ghost commented Jan 12, 2018

The SQL could also be simplified by adding all the smart_scripts lines into 1 DELETE FROM / INSERT INTO query.
I will rework the SQL and post an update. Feel free to comment about other possible improvements.

@Atis6
Copy link

Atis6 commented Jan 12, 2018

Thank you tktokli.
Sorry, I'm a newbie a little bit.

@ghost
Copy link

ghost commented Jan 12, 2018

That is OK. We all learn by getting feedback from other contributors.

@ghost
Copy link

ghost commented Jan 12, 2018

Here is one way of doing it (not sure if more or less documentation is required).

-- Scourge damaged or killed by Gymer's Throw should fulfill quest criteria
UPDATE `creature_template` SET AIName="SmartAI" WHERE `entry` IN (
29887, -- Vargul Doombringer
29889, -- Vargul Blighthound
29890, -- Vargul Deathwaker
29891, -- Vargul Runelord
29892, -- Vargul Slayer
29893, -- Banshee Soulclaimer
29894, -- Vargul Plaguetalon
29897, -- Reanimated Corpse
29934, -- Acolyte of Agony
29935, -- Acolyte of Pain
29943, -- Scourge Proxy (phased)
37893, -- Vegard the Unforgiven
37976  -- Vegard the Unforgiven
);

DELETE FROM `smart_scripts` WHERE `source_type`=0 AND `entryorguid` IN (29887,29889,29890,29891,29892,29893,29894,29897,29934,29935,29943,37893,37976);
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(29887,0,0,0,0,0,100,0,2000,20000,30000,40000,1,1,5000,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vargul Doombringer - In Combat - Say Line 1 (Phase 1) (No Repeat)"),
(29887,0,1,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Vargul Doombringer - On Spellhit Explosion - Get Kill credit"),
(29889,0,0,0,0,0,100,0,6000,10000,16000,23000,11,50047,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vargul Blighthound - In Combat - Cast 'Broken Bone' (Phase 1) (No Repeat)"),
(29889,0,1,0,0,0,100,0,2000,15000,26000,33000,11,50046,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vargul Blighthound - In Combat - Cast 'Gnaw Bone' (Phase 1) (No Repeat)"),
(29889,0,2,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Vargul Blighthound - On Spellhit Explosion - Get Kill credit"),
(29890,0,0,0,0,0,100,0,3000,13000,19000,26000,11,56038,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vargul Deathwaker - In Combat - Cast 'Plaguebolt' (Phase 1) (No Repeat)"),
(29890,0,1,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Vargul Deathwaker - On Spellhit Explosion - Get Kill credit"),
(29891,0,0,0,0,0,100,0,3000,13000,19000,26000,11,56036,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vargul Runelord - In Combat - Cast 'Rune of Destruction' (Phase 1) (No Repeat)"),
(29891,0,10,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Vargul Runelord - On Spellhit Explosion - Get Kill credit"),
(29892,0,0,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Vargul Slayer - On Spellhit Explosion - Get Kill credit"),
(29893,0,0,0,0,0,100,0,4000,7000,9000,12000,11,28993,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Banshee Soulclaimer - In Combat - Cast 'Banshee Wail' (Phase 1) (No Repeat)"),
(29893,0,1,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Banshee Soulclaimer - On Spellhit Explosion - Get Kill credit"),
(29894,0,0,0,0,0,100,0,3000,9000,14000,21000,11,55079,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vargul Plaguetalon - In Combat - Cast 'Swoop' (Phase 1) (No Repeat)"),
(29894,0,1,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Vargul Plaguetalon - On Spellhit Explosion - Get Kill credit"),
(29897,0,0,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Reanimated Corpse - On Spellhit Explosion - Get Kill credit"),
(29934,0,0,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Acolyte of Agony - On Spellhit Explosion - Get Kill credit"),
(29935,0,0,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Acolyte of Pain - On Spellhit Explosion - Get Kill credit"),
(29943,0,0,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Scourge Proxy - On Spellhit Explosion - Get Kill credit"),
(37893,0,0,0,54,0,100,512,0,0,0,0,80,3789300,2,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Just Summoned - Run Script"),
(37893,0,1,2,8,0,100,512,70792,0,0,0,37,0,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Spell Hit(Kill Vegard) - Die"),
(37893,0,2,0,61,0,100,512,0,0,0,0,41,5000,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Spell Hit(Kill Vegard) - Despawn"),
(37893,0,3,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Spellhit Explosion - Get Kill credit"),
(37976,0,0,1,54,0,100,512,0,0,0,0,11,7398,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Just Summoned - Cast Rebirth"),
(37976,0,1,0,61,0,100,512,0,0,0,0,1,0,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Just Summoned - Say Line 0"),
(37976,0,2,3,6,0,100,0,0,0,0,0,1,1,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Death - Say Line 1"),
(37976,0,3,4,61,0,100,512,0,0,0,0,45,2,2,0,0,0,0,19,38001,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Death - Say Line Set Data 2 2 on Light's Vengeance Bunny 2"),
(37976,0,4,0,61,0,100,512,0,0,0,0,45,1,1,0,0,0,0,20,201937,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Death - Say Line Set Data 1 1 on Light's Vengeance"),
(37976,0,5,0,9,0,100,0,0,10,20000,35000,11,70866,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Range - Cast Shadow Blast"),
(37976,0,6,0,2,0,100,0,0,30,15000,25000,11,70886,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Less than 30% HP - Cast Vegard's Thirst"),
(37976,0,7,0,0,0,100,0,3000,7000,25000,35000,11,71003,0,0,0,0,0,2,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - IC - Cast 'Vegard's Touch'"),
(37976,0,8,9,7,0,100,0,0,0,0,0,1,2,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Evade - Say Line 2"),
(37976,0,9,0,61,0,100,512,0,0,0,0,41,5000,0,0,0,0,0,1,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Evade - Despawn"),
(37976,0,10,0,8,0,100,0,55569,0,100,200,33,29943,0,0,0,0,0,7,0,0,0,0.0,0.0,0.0,0.0,"Vegard the Unforgiven - On Spellhit Explosion - Get Kill credit");

I think we should add some kind of distinction between

Since I have never done this quest, nor played a class applicable to this quest line, I would like some feedback on the difference between those 2.


edit: Added a handful of missing name references (in front of "On Spellhit Explosion - Get Kill credit") in the comments.

@Atis6
Copy link

Atis6 commented Jan 12, 2018

Wow, that new codestyle is much better. Thanks.
These 2 NPC's are same, only the model is different, but these 2 is needed for quest criteria too.

image

BTW, I've tested your code, It works as well. :)

@ghost
Copy link

ghost commented Jan 12, 2018

Thank you for the feedback. I think I have seen one or two YouTube videos about it long ago,
it is about before and after Vegard the Unforgiven is resurrected during the event, I guess?

@ghost
Copy link

ghost commented Jan 12, 2018

BTW @Killyana or @dr-j , would you like to check this SQL for wrong or missing content before it is pushed?

@Killyana Killyana self-assigned this Jan 12, 2018
@Atis6
Copy link

Atis6 commented Jan 13, 2018

I think It needs some rework :/
Only 1 killcredit given when explodes. But 1 creature triggers others, it explodes other creatures and you get only 1 killcredit.
I think the best way to set that line get killcredit to action invoker TO neares players cca 20 yard, because it’s phased and only you are the one player in that phase.

@Killyana
Copy link
Contributor

This is not an SAI issue, the quest is working correctly in an older build, all this npcs are in RequiredNpcOrGo so no need to call a kill Credit.

Something is wrong with the kill credit done by aoe, and there's probably many other quests affected by this issue.

@Atis6
Copy link

Atis6 commented Jan 14, 2018

Oh. I though It’s a SAI issue. :)

@ghost
Copy link

ghost commented Jan 14, 2018

Check if the same issue happens with the cannon quest in the Death Knight starting area.
(BTW, the Mine Cart does not work (waypoint issue) so you need GM to get to the ships)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants