Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Combat: Threat issues in raids #21499

Closed
jossuemc opened this issue Feb 25, 2018 · 3 comments
Closed

Core/Combat: Threat issues in raids #21499

jossuemc opened this issue Feb 25, 2018 · 3 comments

Comments

@jossuemc
Copy link

jossuemc commented Feb 25, 2018

Description:
If a tank loses the threat of the boss, that tank isn't able to recover the focus of the boss, not even with a taunt. After using taunt, the boss attacks the tank for 2 seconds, but then it starts to attack the player that stole the aggro. That DPS player has to run around 5 seconds to let the tank recover the threat. However, in heroic instances you get killed before that happens. It seems that DPS players are generating more threat than a tank.

In some special cases, like the boss Festergut, you need 2-3 tanks to switch focus when the main tank has enough stacks of Gastric Bloat and you need to switch tanks. It is not easy to do that, because taunts from the off-tanks are not enough to change the focus of the boss, making the main tank receive more marks of Gastric Bloat than he should, getting killed in the process. I would say that the main issue is that Taunt is not working as it should.

Current behaviour:

Tanks aren't able to recover the threat easily after losing it, Taunt not working as it should.

Expected behaviour:

If the tank loses aggro, he should be able to recover it fast with a Taunt.

Steps to reproduce the problem:

  1. Test a boss like Deathbringer Saurfang and let a tank lose the threat.
  2. Taunt the boss and check how many seconds you need to recover that threat.
  3. May be tested with two tanks on a boss like Festergut (switching aggro).

Branch(es): 3.3.5

TC rev. hash/commit: acdf7be

TDB version: 335.64

Operating system: Win 10 x64

@ghost ghost changed the title Threat issues in raids Core/Combat: Threat issues in raids Feb 25, 2018
@Foereaper
Copy link
Contributor

Experienced the same thing today, though I can't really say for sure since I was only observing and not part of the raid group myself, but had some issues on Naxxramas bosses like 4 horsemen where the bosses would not gain aggro on tank swap at all, and ran back to the original target after taunt duration.

@jackpoz
Copy link
Member

jackpoz commented Feb 25, 2018

@Treeston could you take a look at this ? thanks

@Treeston Treeston self-assigned this Feb 25, 2018
@Treeston
Copy link
Member

I can reproduce - taunt seems to sometimes match threat to the wrong target. I will investigate.

Treeston added a commit that referenced this issue Feb 25, 2018
…ered boost heap iterators. Use ordered iterators instead, this is cheap for our use case anyway. This will make taunt behave consistently again.

Closes #21499.
Ovahlord referenced this issue in The-Cataclysm-Preservation-Project/TrinityCore Jul 22, 2020
…ered boost heap iterators. Use ordered iterators instead, this is cheap for our use case anyway. This will make taunt behave consistently again.

Closes #21499.

# Conflicts:
#	src/server/game/Combat/ThreatManager.cpp
funjoker pushed a commit that referenced this issue Aug 8, 2021
…ered boost heap iterators. Use ordered iterators instead, this is cheap for our use case anyway. This will make taunt behave consistently again.

Closes #21499.

(cherry picked from commit 71b5ed6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants