Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB/Creature: Scarlet Crusader #22055

Closed
DanVS opened this issue Jun 19, 2018 · 9 comments
Closed

DB/Creature: Scarlet Crusader #22055

DanVS opened this issue Jun 19, 2018 · 9 comments

Comments

@DanVS
Copy link
Contributor

DanVS commented Jun 19, 2018

Description:

Scarlet Crusader shall have texts on aggro. But for some reason suggested fix does not work.

Branch(es): 3.3.5

TC rev. hash/commit:

TrinityCore rev. 7187420 2018-06-17 17:03:10 +0200 (q12641 branch) (Unix, RelWithDebInfo, Static)

TDB version: 335.64

Operating system: Ubuntu

Suggested fix:

-- Scarlet Crusader (28529)
DELETE FROM `creature_text` WHERE `CreatureID`=28529;
INSERT INTO `creature_text` (`CreatureID`,`GroupID`,`ID`,`Text`,`Type`,`Language`,`Probability`,`Emote`,`Duration`,`Sound`,`BroadcastTextId`,`TextRange`,`comment`) VALUES 
(28529,0,0,'Death stalks us! Destroy it!',12,0,100,0,0,0,28488,0,'Scarlet Crusader'),
(28529,0,1,'Begone foul demon!',12,0,100,0,0,0,28489,0,'Scarlet Crusader'),
(28529,0,2,'\'Tis the work of the Scourge!',12,0,100,0,0,0,28490,0,'Scarlet Crusader'),
(28529,0,3,'Scourge! Do not let it escape!',12,0,100,0,0,0,28491,0,'Scarlet Crusader');
DELETE FROM `smart_scripts` WHERE `entryorguid`=28529 AND `source_type`=0 and `id`=1;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`event_param5`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(28529,0,1,0,4,0,50,0,0,0,0,0,0,1,0,0,0,0,0,0,1,0,0,0,0,0,0,0,'Scarlet Crusader - On Aggro - Say Line 0');
@ZenoX92
Copy link
Contributor

ZenoX92 commented Jun 19, 2018

The "Shoot" ability is already in DB. No need to remove it and re-add it.

DELETE FROM `smart_scripts` WHERE `entryorguid`=28529 AND `source_type`=0 and `id`=1;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`event_param5`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES 
(28529,0,1,0,4,0,50,0,0,0,0,0,0,1,0,0,0,0,0,0,1,0,0,0,0,0,0,0,'Scarlet Crusader - On Aggro - Say Line 0');

@DanVS
Copy link
Contributor Author

DanVS commented Jun 19, 2018

Fixed 👍

@DanVS
Copy link
Contributor Author

DanVS commented Jun 19, 2018

Can't there be phasing issue?

@Killyana
Copy link
Member

There's 2 versions of this npc : 28529 and 28940 maybe only one have a text on aggro

@offl
Copy link
Contributor

offl commented Jun 19, 2018

The "Shoot" ability is already in DB. No need to remove it and re-add it.

Not quite :)
In the original ACID the standart(order) was: scripts on spawn > OOC > on aggro > in combat > on death
It looks good but every time you change script you must change the whole script

@DanVS
Copy link
Contributor Author

DanVS commented Jun 20, 2018

Killyana, the right one must be 28529.

@ZenoX92
Copy link
Contributor

ZenoX92 commented Jun 20, 2018

@offl, this "standard order" really matters? Or is it just cosmetic?

@offl
Copy link
Contributor

offl commented Jun 20, 2018

Well, I guess it makes scripts more readable

@ZenoX92
Copy link
Contributor

ZenoX92 commented Jun 20, 2018

Cosmetic then :)

And I believe there's a TC policy about not to delete/re-add data that is already in DB.

@DanVS Yes, according to wowhead it's 28529.
http://www.wowhead.com/npc=28529/scarlet-crusader

28940 says other texts.
http://www.wowhead.com/npc=28940/scarlet-crusader

Killyana pushed a commit that referenced this issue Jun 21, 2018
Aokromes pushed a commit to Aokromes/TrinityCore that referenced this issue Jun 23, 2018
Shauren pushed a commit that referenced this issue Sep 29, 2021
Closes #22055

(cherry picked from commit d5a76b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants