DB/Quest: The Soul Devices (10091) incomplete RewardText fix

[ghost]

Description:

• https://www.wowhead.com/quest=10091/the-soul-devices
• https://www.wowhead.com/npc=18893/spymistress-mehlisah-highcrown

RewardText in the quest The Soul Devices (10091) is incomplete, the last 2 sentences are cut short from where the dash ( - ) is placed in the original text. This is similar to what we have seen in many Outland quest texts before, text cut short from where a dash is present in the text (maybe a parsing error from early development, could originally have been a double dash ( -- ) interpreted as SQL comment line? I don't know).

Current behaviour:

SELECT `ID`,`RewardText` FROM `quest_offer_reward` WHERE `ID`=10091;

   ID  RewardText
-----  ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
10091  To'gun was here earlier giving me his report. He should have stayed with you to help!$B$BI sent him back out there to assist Grik'tha. I think they make a cute couple.$B$BSo, these are the soul devices that the Shadow Council were using to enhance their summoning power? They look dangerous to me 

Expected behaviour:

The full RewardText should say:

To'gun was here earlier giving me his report. He should have stayed with you to help!

I sent him back out there to assist Grik'tha. I think they make a cute couple.

So, these are the soul devices that the Shadow Council were using to enhance their summoning power? They look dangerous to me - maybe the Scryers will know what to do with them?

Please, take one of these as a reward for crippling the Shadow Council's operation in the labyrinth.

Suggested fix:

UPDATE `quest_offer_reward` SET `RewardText`="To'gun was here earlier giving me his report. He should have stayed with you to help!$B$BI sent him back out there to assist Grik'tha. I think they make a cute couple.$B$BSo, these are the soul devices that the Shadow Council were using to enhance their summoning power? They look dangerous to me - maybe the Scryers will know what to do with them?$B$BPlease, take one of these as a reward for crippling the Shadow Council's operation in the labyrinth." WHERE `ID`=10091;

I also want to recommend using lowercase class $c (class is neither a name nor nationality in English) in the quest page before the one above:

UPDATE `quest_request_items` SET `CompletionText`="Yes? What can I do for you, $c?" WHERE `ID`=10091;

Steps to reproduce the problem:

1. Get any level 68+ character, then .go creature id 18893
2. .quest add 10091 & .quest complete 10091
3. Open the quest dialogue and click [Continue] to see the RewardText

Branch(es):

3.3.5 (quest text was reworked in patch 4.3.0, so this is not valid for master (and deprecated for BFA))

• https://wow.gamepedia.com/The_Soul_Devices

TC rev. hash/commit:

TC>server debug
TrinityCore rev. 9e069a2 2019-01-09 18:06:30 +0100 (3.3.5 branch) (Win64, RelWithDebInfo, Static)
Using SSL version: OpenSSL 1.1.0h 27 Mar 2018 (library: OpenSSL 1.1.0h 27 Mar 2018)
Using Boost version: 1.65.1
Using MySQL version: 5.6.41
Using CMake version: 3.10.1
Compiled on: Windows 10.0.17134
Automatic database updates are enabled for the following databases: Auth, Characters, World
Worldserver listening connections on port 8085
Realmlist (Realm Id: 1) configured in port 8085
VMAPs status: Enabled. LineOfSight: 1, getHeight: 1, indoorCheck: 1
MMAPs status: Enabled
maps directory located in ./maps. Total size: 252191207 bytes
vmaps directory located in ./vmaps. Total size: 588247501 bytes
mmaps directory located in ./mmaps. Total size: 2152621724 bytes
Using enUS DBC Locale as default. All available DBC locales: enUS
Using World DB: TDB 335.64
TC>_

Operating system: Windows 10 Home x64 Version 1809 (OS Build 17763.253)