Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB/SAI: North Fleet Sailor #22941

Closed
Sorikoff opened this issue Jan 13, 2019 · 3 comments
Closed

DB/SAI: North Fleet Sailor #22941

Sorikoff opened this issue Jan 13, 2019 · 3 comments

Comments

@Sorikoff
Copy link
Contributor

Sorikoff commented Jan 13, 2019

Description:
Implement scripts (Cleave and Shield Slam casting) for Howling Fjord NPC North Fleet Sailor (23866).

Branch(es):
3.3.5 and master

TC rev. hash/commit:
TrinityCore rev. 9faad46 2019-01-12 12:16:23 +0100 (3.3.5 branch) (Unix, Debug, Static) (worldserver-daemon)

TDB version: 335.64

Operating system: *nix

Suggested Fix:

-- North Fleet Sailor (23866)
DELETE FROM `smart_scripts` WHERE `entryorguid`=23866 AND `source_type`=0 AND `id` IN (1,2);
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(23866,0,1,0,0,0,100,0,5000,7000,8000,10000,0,11,15496,0,0,0,0,0,2,0,0,0,0,0,0,0,0,"North Fleet Sailor - In Combat - Cast 'Cleave'"),
(23866,0,2,0,0,0,100,0,6000,10000,11000,15000,0,11,49863,0,0,0,0,0,2,0,0,0,0,0,0,0,0,"North Fleet Sailor - In Combat - Cast 'Shield Slam'");
@ghost
Copy link

ghost commented Jan 13, 2019

1 DELETE FROM / INSERT INTO pair is enough. Looks OK visually otherwise.

@ghost
Copy link

ghost commented Jan 13, 2019

Strictly speaking, you don't need to remove & reinsert existing data. Suggestion:

DELETE FROM `smart_scripts` WHERE `entryorguid`=23866 AND `source_type`=0 AND `id` IN (2,3);
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(23866,0,1,0,0,0,100,0,5000, 7000, 8000,12000,0,11,15496,0,0,0,0,0,2,0,0,0,0,0,0,0,0,"North Fleet Sailor - In Combat - Cast 'Cleave'"),
(23866,0,2,0,0,0,100,0,6000,10000,11000,15000,0,11,49863,0,0,0,0,0,2,0,0,0,0,0,0,0,0,"North Fleet Sailor - In Combat - Cast 'Shield Slam'");

(it is OK to use double quotation marks around texts to avoid having to escape single quotation marks)

@Sorikoff
Copy link
Contributor Author

OK, updated suggested fix. Thanks for your help!

Killyana pushed a commit that referenced this issue Jan 14, 2019
Aokromes pushed a commit to Aokromes/TrinityCore that referenced this issue Jan 30, 2019
Shauren pushed a commit that referenced this issue Nov 21, 2021
…terskorn Scout

Closes #22941
Closes  #22943
Closes #22944
Closes #22947

(cherry picked from commit 09ac56e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants