Grounding Totem not being destroyed

[VincentVanclef]

Description:

Grounding totem is not being consistently destroyed after absorbing a spell.

Current behaviour:

Tested mostly with Jaedenar Cultists/Jaedenar Adepts. Fire blast does full damage and kills it, but fireball and shadowbolt only do 1 damage. Shadow word: pain applies the debuff to the totem, and the first tick of damage kills it. Curse of weakness applies a debuff and does no damage to the totem. When it absorbs a spell that doesn't destroy the totem, it seems to trigger an ICD before it reapplies the totem buff and absorbs another spell.

Expected behaviour:

Grounding totem should be destroyed after redirecting a spell.

Steps to reproduce the problem:

Place grounding totem, have an offensive spell cast at you.

Any other useful links here:

https://wotlkdb.com/?spell=8177
https://wotlkdb.com/?npc=7115
https://wotlkdb.com/?npc=7112

Branch(es):
3.3.5

TC rev. hash/commit:

fbccb09

Operating system:
windows 64 bit

[ipriver]

According to wowwiki:
Patch 2.3.0 (13-Nov-2007): This totem is now destroyed upon redirecting any spell to itself.

Yep, currently, spells that don't deal damage won't destroy a totem and spells like Fear work on the grounding totem so that totem runs away.

As I see 21459 is related to this issue and nobody really fixed it.

[ghost]

According to @ariel- (in #21459 (comment)), the current Magnet implementation is a hack, so I guess the totem handling needs more love and rewriting to work as intended.

[offl]

Still valid in aba0704