DK/Spell Death Grip shoud intrerupt npc cast too

[CraftedRO]

Description:

Death Knight spell Death Grip dosen't intrerupt npc-s / mobs .

Expected behaviour:

Death Knight spell Death Grip shoud intrerupt npc-s / mobs too like it does on players .

Gripping a target will interrupt any cast currently in progress. This can be used to great effect in PvP, interrupting healers or preventing node captures. Casting will be interrupted even if the target is barely moved, such as when engaging a caster at point-blank range.

Steps to reproduce the problem:

1. For a quick reproduction make a Death Knight level 80 , .tele icecrown and go to Sindragosa's Fall - Icecrown , there you'll find some Frostbrood Whelp
2. Use Death Grip on them when they cast Frost Blast.
3. Notice they won't be intrerupted .

Branch(es):

3.3.5

TC rev. hash/commit: e2ba73e

TrinityCore rev. e2ba73e 2021-02-23 02:17:09 +0200 (3.3.5 branch) (Win64, Release, Static)

Operating system:

Windows 10 x64

2021-02-23.21-04-57.mp4

[CraftedRO]

400aef3 still valid, just tried smth like this, it works but for some reason most of the time it break the pull effect not sure why

    void HandleDummy(SpellEffIndex /*effIndex*/)
    {
        if (Unit* target = GetHitUnit())
        {
            if (target->HasUnitState(UNIT_STATE_CASTING))
                target->CastStop(); // Stop casting

            else if (!target->HasAuraType(SPELL_AURA_DEFLECT_SPELLS)) // Deterrence
                target->CastSpell(GetExplTargetDest()->GetPosition(), GetEffectValue(), true);
        }
    }

Here's a video recorded on cata ptr 4.4.0.54670, this is how shoud work:

2024-05-15.11-05-54.mp4

[Aokromes]

yeah a lot of times if you use death grip over a mob that is casting and ain't rooted pull fails.

[Shauren]

Unconditionally interrupting is wrong - it should respect interrupt flags (not all npc spells are interrupted on movement)

[Aokromes]

one good sample of spell that can be interrupted but aint interrupted pulling is https://aowow.trinitycore.info/?npc=29822 lava brust, on cata ptr it's interrupted.

[CraftedRO]

maybe related #18416