Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3.5] Overpowered Demon Minions in Durotar and perhaps elsewhere. #281

Open
click opened this issue May 16, 2011 · 49 comments
Open

[3.3.5] Overpowered Demon Minions in Durotar and perhaps elsewhere. #281

click opened this issue May 16, 2011 · 49 comments

Comments

@click
Copy link
Contributor

click commented May 16, 2011

TrinityCore Rev: 10866+ Release Hash: 241785b635ac+ (Unix, little-endian)
TDB 335.11.36

All demon minions (i.e. Fizzle Darkclaw area and Skull Rock demon minions) in durotar and perhaps elsewhere do ridiculously high damage and have to high HP and Armor

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@click
Copy link
Contributor Author

click commented May 16, 2011

Author: bigfella
Essentially all demons upto and including the zone Tanaris have this "defect." Especially annoying when trying to get the tailoring pattern for the Robes of Arcana for the warlock quest. The Dark Strand Voidcallers minions in Darkshore make the pattern impossible to obtain at level 31, when the quest for Components for the Enchanted Gold Bloodrobe becomes available(http://www.wowhead.com/quest=1796).

@click
Copy link
Contributor Author

click commented May 16, 2011

Author: masken
If you're running your own server, it's possible to work around this issue a little bit by giving your account GM capabilities, selecting the owerpowered demon and typing ".die".

@Aokromes
Copy link
Member

From 5090:

Voidwalker Minion - Burning Blade Apprentice's Minion

level 10, 2157 and 1970 health and high damage

level 11, 1941 and 1717 health and high damage

Imp Minion - Fizzle Darkstorm's Pet

level 12, 1004 and 1049 health and 260 or more damage on a level 16 warrior with 608 health

these are also non elites

Durotar - Thunder Ridge

the health and damage for these pets are too much
the pet owners have normal health (178 and 164) and do normal damage

@Crysicle
Copy link

Confirmed.

Edit: found another one - http://img820.imageshack.us/img820/1097/wowscrnshot021512115936.jpg

Core revision: Trinity Core a3e739e+
Database revision: TDB 335.11.45
Addons: Anticheat1

ghost pushed a commit to rebirth-core/Rebirth---WoW that referenced this issue Feb 14, 2012
@Kline-
Copy link
Contributor

Kline- commented Feb 27, 2012

I've managed to plot the growth pattern for health based on the 3 or 4 known values from WoWHead and other DBs; would this be blizzlike enough to be used as the fix to properly scaling and fixing this? Or are actual sniffs needed instead?

@JasperAppec
Copy link
Contributor

There's not much from sniffs that will help you with this I am afraid. I suggest you post it on the forums in C++ Script Development so further investigation can be done. :)

asido pushed a commit to asido/TrinityCore that referenced this issue Mar 12, 2012
@Crysicle
Copy link

Crysicle commented Aug 5, 2012

Still bugged, found some more bugs that may be linked with this and also a few extra mobs regarding the stats issue.

  1. Voidwalkers do not reset normally(imps do) after combat.

http://i.imgur.com/hNx7k.jpg
http://i.imgur.com/neGLd.jpg

  1. Voidwalkers drop 10-30 lvl loot regardless of their level. Imps also drop coins, though i'm not sure if that isn't supposed to happen.

http://i.imgur.com/r1MlO.jpg
http://i.imgur.com/xhn2x.jpg
http://i.imgur.com/j4Gaz.jpg

  1. Voidwalkers follow you till the end of the world(imps don't).

http://i.imgur.com/SrAGR.jpg

Extra mobs:
Bleakheart Hellcaller's:
-Voidwalker Minion
-Imp Minion

Core revision: Trinity Core 0b98656+
Database revision: TDB 335.11.48
Addons: Anticheat1

@Aokromes
Copy link
Member

Aokromes commented Aug 7, 2012

What about players pets stats?

@gecko32
Copy link
Contributor

gecko32 commented Aug 7, 2012

If refering to above only affects ones spawned by creatures, player ones are diffrent entry

@gecko32
Copy link
Contributor

gecko32 commented Aug 8, 2012

Thanks Vincent is working for me on rev 429130522e

@DjYXA
Copy link
Contributor

DjYXA commented Nov 16, 2012

@Vincent-Michael Please pull

@ghost ghost assigned Subv Nov 16, 2012
@ghost ghost assigned Vincent-Michael Dec 24, 2012
@Pirricli
Copy link
Contributor

Pirricli commented Feb 9, 2013

Does the patch of Vincent-Michael work? Pull it.

@Marikhen
Copy link

The patch works. I might not agree with the values that result from it, but it works.

With the patch Darkfizzle's imp only does about 15-16 damage on fireball and both it and the nearby voidwalker only do 5-6 physical damage. Darkfizzle does about 40 damage on shadowbolt. There are also some warmaul warlocks with imp minions that have the same bugged status out in Nagrand. The imps do about 250 damage with their fireball while their owner does around 450 with shadowbolt, but the owners hit for about 140-200 (mostly) physical to the imp's 37'ish.

If those values are properly "Blizz-like" then so be it, but I'm not entirely sure the physical damage scaling for voidwalkers will be appropriate based on the imps.

@EgoSumThan
Copy link
Contributor

Is this confirmed to be valid and working ?

@Marikhen
Copy link

Unless you're interested more in a response from someone with any sort of authority I just covered that a week ago. It works. The damage values feel low to me post-patch, but I don't recall ever having had to pay much attention to them on retail servers so for all I know they could be spot on for "Blizz-like."

@EgoSumThan
Copy link
Contributor

General request :) Thanks for the answer, I'll look at it.

@NexusTracker
Copy link

@Vincent-Michael working on fab18f6 Please pull.

@Subv
Copy link
Contributor

Subv commented Mar 26, 2013

That's a hack and will not be pulled into the stock TC, we have to find another way

@malcrom
Copy link
Contributor

malcrom commented Jun 2, 2013

I need entries of problem pets.

@joschiwald
Copy link
Contributor

problem is on core side, these npcs have level between 1-80 or something like that, dmg will be calculated on a random lvl, but core will set lvl to owners lvl, but dmg will not recalculated

maybe i will explain this later a bit better

@Justiciar
Copy link

I guess everyone already know but I'm mentioning anyway
confirmed bugged
Hash:� 20a61b6
� �TDB:335.52

@bieleib92
Copy link

Still bugged.

@MetaBarj0
Copy link
Contributor

Is it still open? Could we have a feedback related to the last fix @grentech proposed?

@ghost
Copy link

ghost commented Mar 18, 2017

@MetaBarj0 : the Issue is very much still open, although I am fairly certain the SQL should be corrected and simplified a bit, like this:

UPDATE `creature_template` SET `minlevel`= 1, `maxlevel`= 1 WHERE `entry` IN (8996, 12922);

Although I am also fairly sure this is considered a hack, so the real solution should be something more generic for all the involved creatures.

If the voidwalkers & imps are spawned by NPCs instead of being independent spawns, it should be handled somewhere else (I don't know where).

@Star-lion
Copy link
Contributor

I'm starting to think that these minions should scale just like regular warlock minions using auras to set everything which was something i was working on a LONGG time ago

@ghost
Copy link

ghost commented May 15, 2017

Suggestion from @dikkedeur in issue #19762 :
"change the spell in SmartAI to another summon Voidwalker spell that matches the level and starter zone or change the HP of the Voidwalker."

@Killyana
Copy link
Member

This issue cannot be fixed on DB side the scaling system for pets must be implemented correctly to get this result: http://imgur.com/7EvKMWQ

@offl
Copy link
Contributor

offl commented May 15, 2017

You can use SetActive for them :D
It's the same temporary solution that we currently use in CPP and SAI scripts.

@WOW-Reborn
Copy link

Still an issue here. https://i.imgur.com/4tJqhAd.jpg

@Aokromes Aokromes pinned this issue Jan 11, 2019
@jackpoz jackpoz unpinned this issue Jan 11, 2019
Wyrserth added a commit that referenced this issue Jul 18, 2019
…ecause stat calculation from guardians is already done in Guardian::InitStatsForLevel.

Closes #281.

Signed-off-by: Wyrserth <wyrserth@protonmail.com>
@Wyrserth
Copy link
Contributor

Wyrserth commented Jul 18, 2019

Fixed both cases (demons and snakes), turns out guardians inherited stats from their templates and on top of that they got calculated ones in virtue of being a guardian.

Checked all cases I could find - from Durotar to Ashenvale to Nagrand, everything looks correct to me. Please open a new issue if anyone finds some discrepancies.

@Wyrserth
Copy link
Contributor

There is some wrong DB data in pet_levelstats, reopening this until it gets sorted out.

@Wyrserth Wyrserth reopened this Jul 18, 2019
@Killyana
Copy link
Member

Killyana commented Jul 18, 2019

Maybe stats were updated between classic and wotlk for the pet 8996, if we can find any video from 3.3.5 retail with the health of 8996 visible it will help.

@Pondering133
Copy link

Pondering133 commented Jul 18, 2019

Scouring through my old screenshots, I have one from WOTLK at level 72, Imp has 5096 HP.

Not sure if that helps with scaling.

@Rushor
Copy link
Contributor

Rushor commented Mar 25, 2020

the melee damag is indeed fixed https://i.imgur.com/tTI6zau.jpg

so this only needs spellfix?

@jackpoz jackpoz unpinned this issue Mar 30, 2020
@jackpoz jackpoz pinned this issue Mar 30, 2020
@dr-j dr-j unpinned this issue May 20, 2020
@offl
Copy link
Contributor

offl commented Aug 31, 2020

There is some wrong DB data in pet_levelstats, reopening this until it gets sorted out.

For what entry?

@ghost
Copy link

ghost commented Sep 1, 2020

@Shauren Shauren reopened this Dec 16, 2021
@Killyana
Copy link
Member

The remaining issue here is summoned pets must use pet_levelstats data only if they are summoned by players, otherwise they must use normal stats.
Example: npc 8996 must have: https://youtu.be/hXa9F60EVIE?t=3160
level 10 - 158 hp
level 11 - 178 hp
But on rev. 69dda64 they use numbers from pet_levelstats:
level 10 - 260 hp
level 11 - 291 hp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests