Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shaman/Totem] Fire Totems/Fire Nova should scale with player's crit chance. #3470

Open
lukaslw opened this issue Oct 11, 2011 · 8 comments
Open

Comments

@lukaslw
Copy link

lukaslw commented Oct 11, 2011

Fire totems (Magma Totem, Searing Totem) and Fire Nova spell can crit now, but these spells should scale with player's crit chance.

Fire totems and Fire Nova spell crit very rarely now. With 32% of spell crit chance I had only 2% crits on dummy.
Crit rating of a player doesn't affect the totems or the spell.

Core_rev: 801ab6d
TC 3.3.5a

@Noth
Copy link

Noth commented Oct 12, 2011

confirm this; and please remove fire nova from being a 'pet'.
Fire Nova Totem was a pet.
Fire Nova is a spell like all other normal spells.
http://www.wowwiki.com/Fire_Nova

@drskull
Copy link
Contributor

drskull commented Nov 30, 2011

Fire nova can proc Elemental Devastation
In scripts spell_shaman need to change totem->CastSpell(totem, spellId, true);
to caster->CastSpell(totem, spellId, true);
Shaman will do animation too.

@lynxzor
Copy link

lynxzor commented Jan 9, 2012

Confirmed. Fire totem crit should scale with players crit.

f283a7b

@drskull
Copy link
Contributor

drskull commented Jan 10, 2012

What about Greater Fire Elemental from Fire Elemental Totem ?

@lynxzor
Copy link

lynxzor commented Jan 10, 2012

AoE-wise, he has both a Fire Shield which pulses against all nearby targets every 3 seconds and a Fire Nova which affects all nearby targets and can be cast every 7 seconds or so. Against single targets he also uses a melee attack that does fire damage (and is thus not affected by physical-type debuffs) and a Fire Blast.

Stats: The Fire Friend benefits from our Spellpower, Hit rating/Expertise (his melee attacks are subject to parries, dodges, blocks etc.), Attack Power and Intellect at time of casting only – changes in our stats after cast do not affect him. Because he is not considered a party member, he gets none of our buffs himself, but does benefit from debuffs on a target (specifically: magical damage taken, spell crit chance and general crit chance).

Survival: Immune to all fire-school damage. Gets a passive 90% reduction to all AoE effect damage and cannot be targeted by any RSTS effects which ignore pets. Will NOT benefit from group heal affects which only target party members as he is not considered a member of the party/raid. Will be destroyed if his totem is destroyed or replaced by another.

info from 3.3.2

@drskull
Copy link
Contributor

drskull commented Jan 10, 2012

So, he does not have chance to spell crit like caster

@drskull
Copy link
Contributor

drskull commented Jun 19, 2012

Fire Nova is ok now,
only fire totems need same crit as caster. My pull was rejected so waiting for totem scalling auras

@ghost ghost assigned Subv Nov 18, 2012
@Aokromes Aokromes removed the Legacy label Jan 8, 2016
@Rushor
Copy link
Contributor

Rushor commented Mar 14, 2020

this is still an issue and should be reopened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants