Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dk]Deathknight pvp 4 set bonus #511

Closed
click opened this issue May 16, 2011 · 9 comments
Closed

[dk]Deathknight pvp 4 set bonus #511

click opened this issue May 16, 2011 · 9 comments

Comments

@click
Copy link
Contributor

click commented May 16, 2011

the four piece gladiator set bonus does not work.
should have 100% chance to proc from every root and snare and no internal cooldown.

strangely i have only seen it proc from cairne bloodhoofs http://www.wowhead.com/spell=23931

@click
Copy link
Contributor Author

click commented May 16, 2011

Author: fecker
is this confirmed ?

@click
Copy link
Contributor Author

click commented May 16, 2011

Author: ninugie
confirmed fix this please

@jambonfrite
Copy link

i confirm this

@lendan
Copy link

lendan commented May 4, 2012

http://www.wowhead.com/spell=61257/runic-power-back-on-snare-root
Whenever you are struck by a movement-impairing effect you will generate 15 runic power over 5 sec.
Only few skills/spells proc DK setbonus called "Runic power return"

http://www.wowhead.com/spell=61258 <- Buff whenever ur struck by snare or root http://www.wowwiki.com/Root http://www.wowwiki.com/Snare
Also there is no internal CD on this proc.
http://www.wowhead.com/spell=61257/runic-power-back-on-snare-root#comments:id=732994

Here is proof from retail for almost every skill/spell,ya gotta understand its SUPER hard to find all of em,especially nao :p

Paladin:
Avenger Shield - http://www.youtube.com/watch?v=GBURzSbQfzQ 1:18

Piercing Howl - http://www.youtube.com/watch?v=77B8XGBXarw - 0:21
Hamstring - http://www.youtube.com/watch?v=77B8XGBXarw - 4:56

Death Knight:
Chains of Ice(before desecration) - http://www.youtube.com/watch?v=77B8XGBXarw - 5:29
Chillblains - Not sure,please help to find proof

Druid:
Typhoon (daze after typhoon) - http://www.youtube.com/watch?v=77B8XGBXarw - 1:28
Entangling Roots - http://www.youtube.com/watch?v=XpzEHKVOevw 2:08(7)
its kinda hard so u gotta look close

Mage:
Frostbolt - http://www.youtube.com/watch?v=BYK6OkFwbv8 - 9:05
Frost Nova - http://www.youtube.com/watch?v=77B8XGBXarw - 1:52
Blast Wave - http://www.youtube.com/watch?v=BYK6OkFwbv8 - 4:58
Cone of Cold - http://www.youtube.com/watch?v=BYK6OkFwbv8 - 5:15
Slow - http://www.youtube.com/watch?v=YyBHq0AGfC8 5:49
Frostbite - http://www.youtube.com/watch?v=BYK6OkFwbv8 [Right after cripp there is frostbite proc] - 9:15

Shaman:
Earthbind Totem - http://www.youtube.com/watch?v=77B8XGBXarw - 2:40
Frostshock - http://www.youtube.com/watch?v=BYK6OkFwbv8 - 7:40
Storm, Earth and Fire(Talent) - http://www.youtube.com/watch?v=XpzEHKVOevw 1:39

Rogue:
Crippling Poison - http://www.youtube.com/watch?v=BYK6OkFwbv8 - 1:35
Deadly Throw - Can't find proof,but well this skill is used to slow enemies and their cast speed so cmon :p but if someone can find video proof it'd kewl

Warlock:
Curse of exhaustion - http://www.youtube.com/watch?v=0FYJrb4kv2U 2:33
Shadowflame - http://www.youtube.com/watch?v=BYK6OkFwbv8 7:47

Hunter:
Wing clip - http://www.youtube.com/watch?v=y4zNG7q9Yds - 0:55
Frost trap - shouldnt proc 4P
Concussive Shot - http://www.youtube.com/watch?v=y4zNG7q9Yds - 0:50
Charge (pet) - Im sure it should proc 4P just can't find movie from retial,please help
Counterattack -Im sure it should proc 4P just can't find movie from retial,please help
Entrapment - http://www.youtube.com/watch?v=Kwhj8KM_nJ0 10:32
Venom Web Spray(pet) - Im sure it should proc 4P just can't find movie from retial,please help. It's root like entrapment
Web (pet) - Im sure it should proc 4P just can't find movie from retial,please help.It's root like entrapment

Here is a list of spells/skills which doesn't trigger 4P on Trinitycore and it should if spell isnt listed here it works on TC

Warrior: harmstring,Piercing howl
Rogue: Crippling poison
Shaman: earthbind totem and roots from earthbind. The thing with earthbind as u can see on video proof that EVERY tick proc 4P
Warlock: Curse of exhaustion,shadowflame
Death knight: Chains of ice
Mage: Slow (Spell from arcane tree)
Hunter: Wing Clip,Concussive Shot,Entrapment
Druid: Well with roots its kinda funny,because when u cast it,it doesn't trigger 4P but whenever u take dmg from roots 4P proc,
Feral charge

and here is list of IDs:
http://www.wowhead.com/spell=1715/hamstring
http://www.wowhead.com/spell=12323/piercing-howl

http://www.wowhead.com/spell=3408/crippling-poison

http://www.wowhead.com/spell=38304/earthbind-totem
http://www.wowhead.com/spell=51483/earths-grasp

http://www.wowhead.com/spell=18223/curse-of-exhaustion
http://www.wowhead.com/spell=47897/shadowflame

http://www.wowhead.com/spell=45524/chains-of-ice

http://www.wowhead.com/spell=31589/slow

http://www.wowhead.com/spell=2974/wing-clip
http://www.wowhead.com/spell=5116/concussive-shot
http://www.wowhead.com/spell=19387/entrapment

http://www.wowhead.com/spell=339/entangling-roots

http://www.wowhead.com/spell=16979/feral-charge
http://www.wowhead.com/spell=49376/feral-charge

@lendan
Copy link

lendan commented May 27, 2012

boo so much work and still noone cares,m e n o l i k e y o u :P Im no good at coding but i thought about one thing,if few spell works,isnt it possible to just copy working code and give right IDs?

@betagan
Copy link

betagan commented Sep 16, 2012

Problem is in IsTriggeredAtSpellProcEvent(...), Spells that deal no dmg are not considered "active" and thus dont proc the spell. I made a workaround, defining PROC_EX_BLOCK for the spell. With that flag, active=true although no dmg dealt. I'm pretty sure however there is a better way to fix, but for everyone searching a temp fix, you can use this:

DELETE FROM spell_proc_event where entry = 61257;
INSERT INTO spell_proc_event (entry, SchoolMask, SpellFamilyName, SpellFamilyMask0, SpellFamilyMask1, SpellFamilyMask2, procFlags, procEx, ppmRate, CustomChance, Cooldown)
VALUES (61257, 1<<7, 0, 1<<32, 1<<32, 1<<32, 0x000AAAA8, 0x01 | 0x02 | 0x40, 0, 100, 0);

@Kulix
Copy link

Kulix commented Oct 14, 2012

bump

@ghost ghost assigned Subv Nov 18, 2012
@Rushor
Copy link
Contributor

Rushor commented Jun 12, 2014

debuff of Conflagrate and debuff of http://www.wowhead.com/spell=47897/shadowflame does not work. everything other works really fine

@Aokromes
Copy link
Member

This is why it's bad to merge diferent bugs. Open a new ticket for each bugged set.

@TrinityCore TrinityCore locked and limited conversation to collaborators Jun 12, 2014
conan513 pushed a commit to conan513/SingleCore_TC that referenced this issue Feb 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants