Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deathknight gladiator glove bonus #512

Closed
click opened this issue May 16, 2011 · 5 comments
Closed

Deathknight gladiator glove bonus #512

click opened this issue May 16, 2011 · 5 comments
Assignees

Comments

@click
Copy link
Contributor

click commented May 16, 2011

deathknight pvp gloves should add an additional five runic power generated when using chains of ice

no runic power added

@click
Copy link
Contributor Author

click commented May 16, 2011

Author: fecker
confirming this
http://img262.imageshack.us/g/glovesv.jpg/

@SignFinder
Copy link
Contributor

bug confirmed with today TC revisioon with TDB 43

@Justiciar
Copy link

confirmed.
should give +5 runic power.
Hash:37abe2528c8efa4a99feca0bd0a8e0b5e6fa3efc
Tdb: 335.11.43+
please give a fix.

@betagan
Copy link

betagan commented Sep 16, 2012

Proc is unintentionally caught by SpellIconID, exclude it and it will work.

diff --git a/src/server/game/Entities/Unit/Unit.cpp b/src/server/game/Entities/Unit/Unit.cpp
index 9aec916..cba6b17 100644
--- a/src/server/game/Entities/Unit/Unit.cpp
+++ b/src/server/game/Entities/Unit/Unit.cpp
@@ -8215,7 +8215,7 @@ bool Unit::HandleAuraProc(Unit* victim, uint32 damage, Aura* triggeredByAura, Sp
             // Blood of the North
             // Reaping
             // Death Rune Mastery
-            if (dummySpell->SpellIconID == 3041 || dummySpell->SpellIconID == 22 || dummySpell->SpellIconID == 2622)
+            if (dummySpell->SpellIconID == 3041 || (dummySpell->SpellIconID == 22 && dummySpell->Id != 62459) || dummySpell->SpellIconID == 2622)
             {
                 *handled = true;
                 // Convert recently used Blood Rune to Death Rune

@Kulix
Copy link

Kulix commented Oct 28, 2012

when can we look forward to this getting fixed?

@ghost ghost assigned Subv Nov 18, 2012
raczman pushed a commit to raczman/TrinityCore that referenced this issue Apr 20, 2014
ike3 pushed a commit to ike3/mangosbot that referenced this issue Aug 25, 2014
Add SET names utf8 in ("mr01241_mangos_Isle_of_Conquest.sql")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants