Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Patch-Fix] Mage Water Elemental SpellCheckCast #7372

Closed
e000 opened this issue Aug 13, 2012 · 5 comments
Closed

[Patch-Fix] Mage Water Elemental SpellCheckCast #7372

e000 opened this issue Aug 13, 2012 · 5 comments

Comments

@e000
Copy link
Contributor

e000 commented Aug 13, 2012

commit 735627ff12912c1eaf42b99833e1ff8de8b7a3ae
Author: e <e@cacaw.net>
Date:   Mon Aug 13 04:15:35 2012 +0100

    [BugFix, Mage (Summon Water Elemental)] Summon Water Elemental will now correctly fail if you already have a summoned pet. Before, it would fail and set the cooldown if you tried to cast it while you had another pet out, now it will just fail with the proper message.

https://gist.github.com/ef10d4aa65286e5a9f75

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Star-lion
Copy link
Contributor

i beleive if its dead you should be able to summon a new one

@e000
Copy link
Contributor Author

e000 commented Sep 17, 2012

I agree, but I'm not sure how to implement that properly.

@e000
Copy link
Contributor Author

e000 commented Sep 17, 2012

Should really despawn the pet when it dies, rather than despawning when castes again.

@callmephil
Copy link

may help
// Despawn Water Elemental Before summoning a new one.
if (Creature* pet = caster->ToPlayer()->GetGuardianPet())
pet->DespawnOrUnsummon();

@ghost ghost assigned Subv Nov 13, 2012
@Aokromes
Copy link
Member

If the fix here is valid, plz open a PR.

Shauren added a commit that referenced this issue May 26, 2016
Aokromes pushed a commit to Aokromes/TrinityCore that referenced this issue Jul 20, 2016
joschiwald pushed a commit that referenced this issue Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants