New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DB/FIX] The Battle of Valhalas /Arena/ #8377
Comments
Combat AI scripts might be fine; changing WDB data (like quest_template's RequiredNpcOrGo) is NOT fine. That needs to change. |
Actually... the code is -> The quest_template change was to make sure that the npc's aren't required to be killed by the quest, so it will be via credit. |
After taking the quest just Nesebar nothing happens, but you should call an opponent! |
It fixes all the 5 quests available from the angel.>? |
Yes. |
The script I use is far away from Blizzlike. ;) |
@untaught Can you share it or tell me where to get it ? |
If someone can provide sniffed data for HACKS section and creature addons will be great: UPDATE `quest_template` SET `PrevQuestId`=13214 WHERE `Id`=13215;
UPDATE `quest_template` SET `PrevQuestId`=13215 WHERE `Id`=13216;
UPDATE `quest_template` SET `PrevQuestId`=13216 WHERE `Id`=13217;
UPDATE `quest_template` SET `PrevQuestId`=13217 WHERE `Id`=13218;
UPDATE `quest_template` SET `PrevQuestId`=13218 WHERE `Id`=13219;
-- <HACKS>
UPDATE `creature_template` SET `mindmg`=220,`maxdmg`=240,`attackpower`=240,`dmg_multiplier`=4 WHERE `entry`=32484;
UPDATE `creature_template` SET `mindmg`=220,`maxdmg`=280,`attackpower`=279 WHERE `entry`=31242;
UPDATE `creature_template` SET `mindmg`=240,`maxdmg`=280,`attackpower`=320 WHERE `entry`=31271;
UPDATE `creature_template` SET `mindmg`=180,`maxdmg`=240,`attackpower`=290 WHERE `entry`=31277;
UPDATE `creature_template` SET `maxlevel`=80,`minlevel`=80 WHERE `entry` IN (31271,31277,31242);
UPDATE `creature_template` SET `faction_a`=14,`faction_h`=14,`ainame`='SmartAI' WHERE `entry` IN (31222,31242,31271,31277,14688);
UPDATE `creature_template` SET `mechanic_immune_mask`=(mechanic_immune_mask)|32|256|512|2048|8192|65536|8388608|33554432 WHERE `entry`=14688;
UPDATE `creature_template` SET `faction_a`=14,`faction_h`=14,`ainame`='SmartAI' WHERE `entry` IN (31191,31192,31194,31196);
UPDATE `creature_template` SET `mindmg`=346,`maxdmg`=499,`attackpower`=287 WHERE `entry`=31192;
UPDATE `creature_template` SET `mindmg`=300,`maxdmg`=350,`attackpower`=250 WHERE `entry`=31194;
UPDATE `creature_template` SET `mindmg`=226,`maxdmg`=270,`attackpower`=221 WHERE `entry`=31196;
-- </HACKS>
DELETE FROM `smart_scripts` WHERE `entryorguid` IN (14688,31222,31242,31271,31277) AND `source_type`=0;
DELETE FROM `smart_scripts` WHERE `entryorguid`=1468800 AND `source_type`=9;
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(14688,0,0,0,0,0,100,0,14500,15000,14500,15000,11,61162,0,0,0,0,0,2,0,0,0,0,0,0,0,'In Combat - Cast Engulfing Strike'),
(14688,0,1,0,0,0,100,0,19500,20000,19500,20000,11,61163,0,0,0,0,0,1,0,0,0,0,0,0,0,'In Combat - Cast Fire Nova'),
(14688,0,2,0,0,0,100,0,29500,30000,44500,45000,80,1468800,1,0,0,0,0,1,0,0,0,0,0,0,0,'In Combat - Run Timed Action List'),
(14688,0,3,0,6,0,100,0,0,0,0,0,15,13219,0,0,0,0,0,16,0,0,0,0,0,0,0,'On Death - Give Quest Credit'),
(14688,0,4,0,7,0,100,0,0,0,0,0,28,0,0,0,0,0,0,0,0,0,0,0,0,0,0,'On Evade - Remove All Auras'),
(31222,0,0,0,6,0,100,0,0,0,0,0,15,13215,0,0,0,0,0,16,0,0,0,0,0,0,0,'On Death - Give Quest Credit'),
(31222,0,1,0,0,0,100,0,2000,3000,8000,8500,11,38243,0,0,0,0,0,5,0,0,0,0,0,0,0,'In Combat - Cast Mind Flay'),
(31222,0,2,0,0,0,100,0,5000,5500,20000,20500,11,22884,1,0,0,0,0,1,0,0,0,0,0,0,0,'In Combat - Cast Psychic Scream'),
(31222,0,3,0,0,0,100,0,0,500,12000,12500,11,61055,0,0,0,0,0,1,0,0,0,0,0,0,0,'In Combat - Cast Summon Bone Spiders'),
(31242,0,0,0,6,0,100,0,0,0,0,0,15,13216,0,0,0,0,0,16,0,0,0,0,0,0,0,'On Death - Give Quest Credit'),
(31242,0,1,0,0,0,100,0,5000,5500,12000,12500,11,61170,1,0,0,0,0,5,0,0,0,0,0,0,0,'In Combat - Cast Flash Freeze'),
(31242,0,2,0,4,0,100,0,0,0,0,0,11,61165,0,0,0,0,0,1,0,0,0,0,0,0,0,'On Aggro - Cast Frostbite Weapon'),
(31242,0,3,0,0,0,100,0,1500,2000,5000,5500,11,61168,0,0,0,0,0,5,0,0,0,0,0,0,0,'In Combat - Use Throw'),
(31242,0,4,0,0,0,100,0,13000,135000,28000,28500,11,57635,1,0,0,0,0,2,0,0,0,0,0,0,0,'In Combat - Use Disengage'),
(31271,0,0,0,6,0,100,0,0,0,0,0,15,13217,0,0,0,0,0,16,0,0,0,0,0,0,0,'On Death - Give Quest Credit'),
(31271,0,1,0,0,0,100,0,3000,3500,5000,5500,11,61070,0,0,0,0,0,2,0,0,0,0,0,0,0,'In Combat - Use Smash'),
(31271,0,2,0,0,0,100,0,5000,5500,15000,15500,11,61065,0,0,0,0,0,1,0,0,0,0,0,0,0,'In Combat - Use War Stomp'),
(31277,0,0,0,6,0,100,0,0,0,0,0,15,13218,0,0,0,0,0,16,0,0,0,0,0,0,0,'On Death - Give Quest Credit'),
(31277,0,1,0,0,0,100,0,14500,15000,14500,15000,11,61133,0,0,0,0,0,2,0,0,0,0,0,0,0,'In Combat - Use Punt'),
(31277,0,2,0,0,0,100,0,19500,20000,19500,20000,11,61134,0,0,0,0,0,5,0,0,0,0,0,0,0,'In Combat - Use Leap'),
(31277,0,3,0,0,0,100,0,16500,17000,16500,17000,11,13737,0,0,0,0,0,2,0,0,0,0,0,0,0,'In Combat - Use Mortal Strike'),
(31277,0,4,0,12,0,100,0,0,20,30000,30000,11,61140,0,0,0,0,0,2,0,0,0,0,0,0,0,'On Target Below 20% HP - Use Execute'),
(1468800,9,0,0,0,0,100,0,0,0,0,0,11,42716,0,0,0,0,0,1,0,0,0,0,0,0,0,'Cast Root On self'),
(1468800,9,1,0,0,0,100,0,0,0,0,0,11,61144,1,0,0,0,0,1,0,0,0,0,0,0,0,'Cast Fire Shield'),
(1468800,9,2,0,0,0,100,0,5000,5000,0,0,11,61145,0,0,0,0,0,1,0,0,0,0,0,0,0,'Ember Shower'),
(1468800,9,3,0,0,0,100,0,10000,10000,0,0,28,61145,0,0,0,0,0,1,0,0,0,0,0,0,0,'Remove Aura From Ember Shower'),
(1468800,9,4,0,0,0,100,0,5000,5000,0,0,28,61144,0,0,0,0,0,1,0,0,0,0,0,0,0,'Remove Aura From Fire Shield'),
(1468800,9,5,0,0,0,100,0,0,0,0,0,28,42716,0,0,0,0,0,1,0,0,0,0,0,0,0,'Remove Aura From Root');
UPDATE `creature_template` SET `ainame`='SmartAI' WHERE `entry`=31135;
DELETE FROM `smart_scripts` WHERE `entryorguid`=31135 AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(31135,0,0,1,19,0,100,0,13214,0,0,0,12,31191,1,120000,0,0,0,8,0,0,0,8184.3,3506.3,625.63,0.3,'On Quest Accepted 13214 - Summon Father Jhadras'),
(31135,0,1,2,61,0,100,0,0,0,0,0,12,31192,1,120000,0,0,0,8,0,0,0,8187.1,3501.9,625.11,0.5,'Link With Event 0 - Summon Masud'),
(31135,0,2,3,61,0,100,0,0,0,0,0,12,31194,1,120000,0,0,0,8,0,0,0,8189.3,3498.84,624.97,0.4,'Link With Event 1 - Summon Talla'),
(31135,0,3,0,61,0,100,0,0,0,0,0,12,31196,1,120000,0,0,0,8,0,0,0,8191.93,3495.1,625.1,0.6,'Link With Event 2 - Summon Rith'),
(31135,0,4,0,19,0,100,0,13215,0,0,0,12,31222,1,120000,0,0,0,8,0,0,0,8187.83,3500.3,624.96,0.53,'On Quest Accepted 13215 - Summon Khit''rix the Dark Master'),
(31135,0,5,0,19,0,100,0,13216,0,0,0,12,31242,1,120000,0,0,0,8,0,0,0,8187.83,3500.3,624.96,0.53,'On Quest Accepted 13216 - Summon Sigrid Iceborn'),
(31135,0,6,0,19,0,100,0,13217,0,0,0,12,31271,1,120000,0,0,0,8,0,0,0,8187.83,3500.3,624.96,0.53,'On Quest Acceptet 13217 - Summon Carnage'),
(31135,0,7,0,19,0,100,0,13218,0,0,0,12,31277,1,120000,0,0,0,8,0,0,0,8187.83,3500.3,624.96,0.53,'On Quest Acceptet 13218 - Summon Thane Banahogg'),
(31135,0,8,0,19,0,100,0,13219,0,0,0,12,14688,1,120000,0,0,0,8,0,0,0,8187.83,3500.3,624.96,0.53,'On Quest Accepted 13219 - Summon Prince Sandoval');
DELETE FROM `smart_scripts` WHERE `entryorguid` IN (31191,31192,31194,31196);
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(31191,0,0,0,0,0,100,0,1000,1500,5000,5500,11,25054,0,0,0,0,0,2,0,0,0,0,0,0,0,'In Combat - Cast Holy Smite'),
(31191,0,1,0,14,0,100,0,3000,4000,6000,7000,11,15586,1,0,0,0,0,1,0,0,0,0,0,0,0,'In Combat - Cast Heal'),
(31192,0,0,0,0,0,100,0,1000,1500,3000,3500,11,15496,0,0,0,0,0,2,0,0,0,0,0,0,0,'In Combat - Use Cleave'),
(31192,0,1,0,0,0,100,0,2000,2500,5000,5500,11,41057,0,0,0,0,0,2,0,0,0,0,0,0,0,'In Combat - Use Whirlwind'),
(31194,0,0,0,0,0,100,0,1000,1500,4000,4500,11,14873,0,0,0,0,0,2,0,0,0,0,0,0,0,'In Combat - Use Sinister Strike'),
(31196,0,0,0,6,0,100,0,0,0,0,0,15,13214,0,0,0,0,0,16,0,0,0,0,0,0,0,'On Death - Give Quest Credit'),
(31196,0,1,0,0,0,100,0,2000,2500,14000,14500,11,61044,1,0,0,0,0,1,0,0,0,0,0,0,0,'In Combat - Use Demoralizing Shout'),
(31196,0,2,0,0,0,100,0,3000,3500,7000,7500,11,58461,0,0,0,0,0,2,0,0,0,0,0,0,0,'In Combat - Use Sunder Armor'); |
Thank you : ) |
Do you have something for the [Quest] Banshee's Revenge ? That is the quest you need to complete to activate the quest line for the battle of valhalas. I wrote it up here. #10848 |
I found the fix for Banshees Revenge. |
I don't see any fix for that quest. I have some preliminary work done on it, but I still need to sniff some missing data. |
That would be awesome. |
@KirkHammett https://gist.github.com/JunkyBulgaria/3943417 Just remove the hacks for quest template, creature template npc's since they are not sniffed yet and i used custom values. |
That has a lot of custom data, I already sniffed a lot of info and I can finish it now. I can use those SET @ declarations though, so you guys have a better idea what's what. |
Nice work. You need to include #10848 or work on a proper fix for Banshees Revenge. Banshees Revenge sends you to the Battle of Valhalas. Also maybe work on the fix for Zun'Drak Arena. The last boss in that arena doesn't spawn and you can't complete it. |
Or, I can work on my life. |
Kirk deal with it, there's always a fixes beggars anywhere. ^^ |
Eh, I don't really care to be honest. I just fix what I want. That's the fun part of an open source, there is no boss. |
Fixes TrinityCore#8377 Consists of: 1) Battle at Valhalas: Fallen Heroes (13214) 2) Battle at Valhalas: Khit'rix the Dark Master (13215) 3) Battle at Valhalas: The Return of Sigrid Iceborn (13216) 4) Battle at Valhalas: Carnage! (13217) 5) Battle at Valhalas: Thane Deathblow (13218) 6) Battle at Valhalas: Final Challenge (13219)
I found out that the Icecrown Arena does not work.
There's the fix i found on the internet and cleared it a while.
https://gist.github.com/3943417
It fixes all the 5 quests available from the angel.
The text was updated successfully, but these errors were encountered: