Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spells with Spelleffect USE_OBJECT without conditions #8722

Closed
Gacko opened this issue Dec 20, 2012 · 15 comments
Closed

Spells with Spelleffect USE_OBJECT without conditions #8722

Gacko opened this issue Dec 20, 2012 · 15 comments

Comments

@Gacko
Copy link
Contributor

Gacko commented Dec 20, 2012

Note to myself: Search for spells fitting the above requirements. Exploit...

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@joschiwald
Copy link
Contributor

what about a condition check on core-side after load conditions in debug mode?

@Gacko
Copy link
Contributor Author

Gacko commented Dec 20, 2012

I'm talking about missing target conditions for spells with implicit target types. Like in 2a5fcdd And as mentioned: It's more a note to myself.

@joschiwald
Copy link
Contributor

i know what you mean, this was a suggestion for you

@joschiwald
Copy link
Contributor

take a look at http://paste2.org/p/2626663 :D
and look for effect: 86 ^^

@Gacko
Copy link
Contributor Author

Gacko commented Dec 20, 2012

Ah, now I got it... Could you filter on SPELL_EFFECT_ACTIVATE_OBJECT please?

@joschiwald
Copy link
Contributor

@ghost ghost assigned Vincent-Michael Dec 21, 2012
@Vincent-Michael
Copy link
Contributor

http://paste2.org/p/2627776 (is not done, come tomorrow more)

edit: update: http://paste2.org/p/2630496

@Gacko
Copy link
Contributor Author

Gacko commented Jan 22, 2013

@Vincent-Michael @joschiwald Can be closed?

@Gacko Gacko closed this as completed Feb 4, 2013
@Subv
Copy link
Contributor

Subv commented Feb 4, 2013

No.

@Subv Subv reopened this Feb 4, 2013
@Aokromes Aokromes assigned Gacko and unassigned Vincent-Michael Feb 5, 2014
@Aokromes
Copy link
Member

Gacko, any new on this?

@Gacko
Copy link
Contributor Author

Gacko commented Jun 26, 2014

Not mine, ask Joschi.

@danlapps
Copy link
Contributor

Is this still WIP or has it been completly dropped ?

@Aokromes
Copy link
Member

@Vincent-Michael or @joschiwald anything here can be merged?

@Killyana
Copy link
Contributor

This was fixed If I'm not wrong.

@Killyana
Copy link
Contributor

Dup #21078

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants