-
Notifications
You must be signed in to change notification settings - Fork 6k
-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spells with Spelleffect USE_OBJECT without conditions #8722
Comments
what about a condition check on core-side after load conditions in debug mode? |
I'm talking about missing target conditions for spells with implicit target types. Like in 2a5fcdd And as mentioned: It's more a note to myself. |
i know what you mean, this was a suggestion for you |
take a look at http://paste2.org/p/2626663 :D |
Ah, now I got it... Could you filter on SPELL_EFFECT_ACTIVATE_OBJECT please? |
http://paste2.org/p/2627004 ? :D https://github.com/joschiwald/TrinityCore/tree/conditions_check if you want ... ^^ |
http://paste2.org/p/2627776 (is not done, come tomorrow more) edit: update: http://paste2.org/p/2630496 |
@Vincent-Michael @joschiwald Can be closed? |
No. |
Gacko, any new on this? |
Not mine, ask Joschi. |
Is this still WIP or has it been completly dropped ? |
@Vincent-Michael or @joschiwald anything here can be merged? |
This was fixed If I'm not wrong. |
Dup #21078 |
Note to myself: Search for spells fitting the above requirements. Exploit...
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: