Core/Cmake: Allow settings to detach custom scripts #11617

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@Ascathor

Allow to remove coupled custom scripts to regular scripts on build.
Meaning, if you change custom scripts and have this enabled, only custom scripts are rebuilt and core scripts are untouched. Disabled by default.
Original Code by @LilleCarl.

@Ascathor Ascathor Core/Cmake: Allow settings to detach custom scripts
Allow to remove coupled custom scripts to regular scripts on build.
Meaning, if you change custom scripts and have this enabled, only custom scripts are rebuilt and core scripts are untouched. Disabled by default.
Original Code by @LilleCarl.
66c0aa5
@jackpoz
TrinityCore member

Is there a purpose for this ? We already have:

  • PCH with scripts
  • PCH without scripts
  • no-PCH with scripts
  • no-PCH without scripts

In which case these configurations aren't enough already and a new cmake option is required ?

@Lillecarl

@jackpoz If we do not want to build all instance scripts, but wants to build custom scripts..

@jackpoz
TrinityCore member

Then would it make more sense to just move Custom scripts cmake file into "game" project ? it's empty by default anyway

@Lillecarl

Game project is not empty at all :P

@Shauren
TrinityCore member

"Custom" is empty

On the other hand, spell scripts are also always included, even if SCRIPTS was not chosen

@Ascathor Ascathor closed this Jun 23, 2014
@Ascathor

I assume this is not entirely valid anymore, so I close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment