Core/Cmake: Allow settings to detach custom scripts #11617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to remove coupled custom scripts to regular scripts on build. Meaning, if you change custom scripts and have this enabled, only custom scripts are rebuilt and core scripts are untouched. Disabled by default. Original Code by @Lillecarl.
|
Is there a purpose for this ? We already have:
In which case these configurations aren't enough already and a new cmake option is required ? |
|
@jackpoz If we do not want to build all instance scripts, but wants to build custom scripts.. |
|
Then would it make more sense to just move Custom scripts cmake file into "game" project ? it's empty by default anyway |
|
Game project is not empty at all :P |
|
"Custom" is empty On the other hand, spell scripts are also always included, even if SCRIPTS was not chosen |
|
I assume this is not entirely valid anymore, so I close this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to remove coupled custom scripts to regular scripts on build.
Meaning, if you change custom scripts and have this enabled, only custom scripts are rebuilt and core scripts are untouched. Disabled by default.
Original Code by @Lillecarl.