Core: Trigger OnSave hook for PlayerScript

[Rochet2]

OnSave is not triggered anywhere.
This adds the call to the SaveToDB function for player.

Unsure if should be triggered elsewhere as well :)

[jackpoz]

what about https://github.com/Rochet2/TrinityCore/blob/OnPlayerSave/src/server/game/Entities/Player/Player.cpp#L1779 ?

[Rochet2]

Hmm, I see.
: |
I feel a bit sad that its there though, and not in the actual save function.
So its not triggered for example if .save is used and many other occasions where the hook would actually be used. (Every time the player is saved)

Modified it to remove the original hook call.
This way its called every time the player is actually saved to DB.

[jackpoz]

is it called even when the player is created ?

[Rochet2]

Yes, since it doesnt check for the create flag.
could use if (!create) // call hook
if you dont like that.

[Warpten]

Would be better to not save on player creation

[Rochet2]

Anything to get this through : |

[Warpten]

Lol, i could be an asshole and ask you to squash these into one commit ... But i won't :p

[Rochet2]

Lol, i could be an asshole and ask you to squash these into one commit ... But i won't :p

I was kinda waiting for that, but thanks ;)