Core/Spells: Implement Periodic mechanics #12228
Conversation
| bool Unit::isSpellCrit(Unit* victim, SpellInfo const* spellProto, SpellSchoolMask schoolMask, WeaponAttackType attackType) const | ||
| bool Unit::IsSpellCrit(Unit* victim, SpellInfo const* spellProto, SpellSchoolMask schoolMask, WeaponAttackType attackType) const | ||
| { | ||
| if (roll_chance_f(GetUnitSpellCriticalChance(victim, spellProto, schoolMask, attackType))) |
There was a problem hiding this comment.
you might just "return roll_chance_f(...)" here
|
this is great 👍 |
|
Should be gone now Runico :) |
|
http://prntscr.com/3qgxml - Now Healing Spells are bugged (Maximal healing: 1 hp) |
| // use float as more appropriate for negative values and percent applying | ||
| float heal = float(int32(healamount) + DoneTotal) * DoneTotalMod; | ||
| // Done Percentage for DOT is already calculated, no need to do it again. The percentage mod is applied in Aura::HandleAuraSpecificMods. | ||
| float heal = float(int32(healamount) + DoneTotal) * damagetype == DOT ? 1.0f : SpellHealingPctDone(victim, spellProto); |
There was a problem hiding this comment.
operator precedence derp here, multiplication happens before comparison
float heal = float(int32(healamount) + DoneTotal) * (damagetype == DOT ? 1.0f : SpellHealingPctDone(victim, spellProto));
|
Fixed ? |
|
yes SmythX |
|
Can you show me what's fixed ? (can you make fast patch/diff to for fix), because i already added this script into my source. |
|
check shaurens comment |
Replace with:
This ? |
|
his comment... |
|
Old: New, fixed: |
|
Okay, TNX! |
|
Closes #5959 |
|
why i cant see the changes on commit? |
|
they are squashed |
|
Hmmmmm ? i didn't understand you |
Change behaviour of single target periodic aura ticks to be more blizzlike Also add some missing handling of SPELL_AURA_MOD_CREATURE_AOE_DAMAGE_AVOIDANCE Fixes Deep wounds and Chimera Shot Serpent Remove an ancient hack with Drain Soul, spell id 100001 can now be deleted from spell_dbc table Allows Rolling dot mechanics and allows DK's to roll diseases with pestilence, see link for info: http://forums.elitistjerks.com/topic/82503-frost-dps-in-333this-will-be-a-day-long-remembered/page-88
|
Cool! |
Core/Spells: Implement Periodic mechanics
|
BTW what was wrong with Deep Wounds and Chimera Shot Serpent? |
|
Now all pets (their HP is bugged), now pet have less hp... |
|
thats not related to this SmythX... |
|
Hmm, I'll try to find problem, cuz my PET HP was okay before few days, and when i add some of latest patches it's very bugged... I will remove patch and test again... If I find problem I'll report it ;) |
Change behaviour of single target periodic aura ticks to be more blizzlike
Also add some missing handling of SPELL_AURA_MOD_CREATURE_AOE_DAMAGE_AVOIDANCE
Fixes Deep wounds and Chimera Shot Serpent
Remove an ancient hack with Drain Soul, spell id 100001 can now be deleted from spell_dbc table
Allows Rolling dot mechanics and allows DK's to roll diseases with pestilence,
see link for info:
http://forums.elitistjerks.com/topic/82503-frost-dps-in-333this-will-be-a-day-long-remembered/page-88