Updating DataStores #13508
Updating DataStores #13508
Conversation
|
why u change WorldSafeLocsEntryfmt? I don't have any WorldSafeLocs.dbc file. |
|
It was a typo from previous old commit. That file was still for 4.3.4 and I haven't looked into it |
… to db2 + wasn't used in core at all?)
…SlotPrices.dbc, BannedAddOns.dbc, BarberShopStyle.dbc structs
|
Yeah, I know that AreaPOI is now db2 but it wasn't used in core at all. Maybe other devs can remember why it was there. |
|
DBFilesClientList.h needs to be updated i think. A lot of missing or useless files. I added "DBFilesClient\WorldSafeLocs.dbc", and extracted properly my missing file :). |
|
There were a lot of discussion on irc about renaming dbc structs to official blizz names (see: http://pastebin.com/vHrJkpQn ). The main problem is that blizzard uses inconsistent names (MapID, InstanceID, ContinentID - all mean the same) and float arrays for coords (instead of xyz). Other than that it's all OK. I would like to hear other developer input on this before I continue my work. Options are:
|
…harTitle.dbc structs
…s.dbc, CreatureDisplayInfo.dbc, CreatureDisplayInfoExtra.dbc structs
| ExpansionRequirementContainer const& GetRaceExpansionRequirements() const { return _raceExpansionRequirementStore; } | ||
| uint8 const GetRaceExpansionRequirement(uint8 race) |
There was a problem hiding this comment.
const on value return does not make any sense (and will trigger warnings on certain compilers)
also the method should be made const as whole
uint8 GetRaceExpansionRequirement(uint8 race) const
the same applies to GetClassExpansionRequirement
There was a problem hiding this comment.
Ok, I'll fix this soon.
…reatureSpellData.dbc, CreatureType.dbc, CurrencyTypes.dbc, DestructibleModelData.dbc structs
|
@xerkoss I will fix custom sql formats after I'm done with files. |
…urabilityQuality.dbc, EmotesEntry.dbc, EmotesText.dbc, Faction.dbc, FactionTemplate.dbc structs
…, GlyphProperties.dbc, GlyphSlot.dbc, GuildPerkSpells.dbc structs
|
@streetrat looks like this pr does something similar to b4a9f47 |
|
What happened to "just few updates per pull request"? Isn't adding all of them to a single pull request going to make this take ages to be reviewed and eventually work start getting overlapped? Just wondering :) |
|
im fixing build and adding some comments for this, please open a new PR for the new updates. |
I will be updating datastores, one per commit as requested. I'll keep PR open and keep adding changes.