Fixes inability to find OpenSSL version in new OpenSSL #14284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new OpenSSL has a space between # and define, breaking the old regex, this new regex can find it again
|
Related to #14276? |
|
No it isnt, although if that PR goes through, this one will need redoing, will have to examine it to see if needed at all, as it dosnt seem to try and get the version from the file |
|
From what I can see that PR removes the version check for OpenSSL all together rather then fixes it |
Closed
|
Thanks for the PR however we took the fix directly from upstream since their changed regex is safer/more strict. |
|
No trouble, sorry I wasn't more help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new OpenSSL has a space between # and define, breaking the old regex, this new regex can find it again