Core/Battleground: Removed _CheckSafePositions, this is handled by areatriggers now.

[Golrag]

Removed _CheckSafePositions, this is handled by areatriggers now.

Any feedback is welcome ! :)

About the areatriggers for starting areas, should I move them to Battleground::HandleAreatrigger or handle them in the specific battlegroundclass ? (Like BattlegroundTP::HandleAreatrigger)

Edit: Updated to 007ab5b

Added missing alterac valley areatriggers
Removed m_StartMaxDist

[Takenbacon]

👍

[jackpoz]

I see https://github.com/TrinityCore/TrinityCore/pull/14570/files#diff-2d7bc8b5f9669823a0062232320c5d19L313 has been removed, where is it handled in the new code ?

[Golrag]

It's not handled in the new code, I can do it if you want, but I didn't feel like it should, cause on retail it is easy to leave those areatriggers (well, it's easy in Twin Peaks horde or the other one with pandaren mine, goblin mine...). So if you want me to use it, I would like to remove the "(possible expoit)" part :p

[Carbenium]

@Golrag: is this PR finished?

[Golrag]

@Carbenium haven't looked at this PR for a long time. Will take a look at it asap
Edit: this is finished :)

[ghost]

The title should contain a short description after "Core/Battleground:", something like
Core/Battleground: Remove m_StartMaxDist and _CheckSafePositions
Maybe this is just cosmetic, but it should be fixed for the commit log
(unless the content of the PR is authored directly into the source with a closing reference back to this PR).

[Takenbacon]

@Golrag Can you bring back the old _CheckSafePositions() checks, but keep the area triggers you've added? While area triggers are more accurate and cleanly handled, there needs to be some sort of fallback because they are also very easily exploitable (e.g. all one would have to do is prevent the client from sending the CMSG_AREATRIGGER opcode and they would never get teleported back, which is easier than it sounds).

[Golrag]

@Takenbacon mh, the purpose of this PR is to replace the current implementation with a more blizzlike one. But tbh, I don't know what happens on retail when you get out of the starting zone without triggering CMSG_AREATRIGGER

[Aokromes]

This branch has conflicts that must be resolved
Use the command line to resolve conflicts before continuing.

[Golrag]

Woops, will have to re-create everything