Core/Spells Add support for quest Torch Tossing/More Torch Tossing #14776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class spell_midsummer_braziers_hit_AuraScript : public AuraScript | ||
| { | ||
| PrepareAuraScript(spell_midsummer_braziers_hit_AuraScript); |
There was a problem hiding this comment.
You forgot Validate() there. It has been standard for most scripts and we should keep it that way imo.
|
Good job though 👍 |
sirikfoll
force-pushed
the
SpellMidsummer
branch
3 times, most recently
from
110b492
to
4401d0b
Compare
| player->CastSpell(player, SPELL_TORCH_TOSSING_TRAINING_SUCCESS_ALLIANCE, true); | ||
| else if (player->GetTeam() == HORDE) | ||
| player->CastSpell(player, SPELL_TORCH_TOSSING_TRAINING_SUCCESS_HORDE, true); | ||
| player->RemoveAura(SPELL_BRAZIERS_HIT); |
| @@ -0,0 +1,2 @@ | |||
| INSERT INTO `spell_script_names` (`spell_id`, `ScriptName`) VALUES | |||
There was a problem hiding this comment.
INSERT INTO queries need a DELETE FROM query first to avoid errors. Insert the following line as a new line 1:
DELETE FROM `spell_script_names` WHERE `spell_id`= 45724 AND `ScriptName`= 'spell_midsummer_braziers_hit';This will make it possible to run the SQL more than one time and avoid errors on subsequent executions.
|
@joschiwald: is this ready? |
MitchesD
added a commit
that referenced
this pull request
Jun 23, 2015
Core/Spells Add support for quest Torch Tossing/More Torch Tossing
2 tasks
2 tasks
DDuarte
added a commit
that referenced
this pull request
Jul 12, 2015
Merge pull request #14776 from sirikfoll/SpellMidsummer Core/Spells Add support for quest Torch Tossing/More Torch Tossing (cherry picked from commit 8197467) by sirikfoll --- Rename 2015_08_29_00_world.sql to 2015_06_23_01_world.sql (cherry picked from commit 352703e) by MitchesD --- Scripts/Spells: fix codestyle thanks @whoami (cherry picked from commit 0cba555) by MitchesD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #6879