[3.3.5][6.x]Core/Unit: Do not remove auras from Pets and Guardians after evading #16503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Rushor
commented
Feb 8, 2016
Rushor
commented
- this adds free space for further adjustments
- this fixes [3.3.5][6.x] Guardians evade issue #14347
- originally work by @mik1893
|
this also fixes following bug:
result: ghoul will evade and blind will be removed. blind should never be removed. this pr fixes that issue |
| @@ -259,7 +259,7 @@ bool CreatureAI::_EnterEvadeMode(EvadeReason /*why*/) | |||
|
|
|||
| // don't remove vehicle auras, passengers aren't supposed to drop off the vehicle | |||
| // don't remove clone caster on evade (to be verified) | |||
There was a problem hiding this comment.
Now these comments possible should be moved to Unit.cpp
Rushor
changed the title
* this adds free space for further adjustments * this fixes #14347
| @@ -4113,6 +4113,16 @@ void Unit::RemoveArenaAuras() | |||
| } | |||
| } | |||
|
|
|||
| void Unit::RemoveAurasOnEvade() | |||
| { | |||
| if (IsCharmedOwnedByPlayerOrPlayer()) // if it is a player owned creature it should not remove the aura | |||
There was a problem hiding this comment.
any news on this? would you like to improve sth. here?
There was a problem hiding this comment.
Looks good to me™. I am fairly sure @ccrs meant it should look like this.
|
@Rushor is this PR ready to be merged ? |
|
yep, i tested this since 2 months now - i didn't found any new issues with it |
|
merge it then please |
DDuarte
pushed a commit
that referenced
this pull request
Apr 28, 2016
[3.3.5][6.x]Core/Unit: Do not remove auras from Pets and Guardians after evading (cherry picked from commit e869ccb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.