Core/Scripts Corrections on Halion's Encounter #16725

sirikfoll · 2016-03-04T22:41:32Z

Changes proposed:
(Everything that i did here was confirmed in retail 6.2.3.20886)

Fixed the proportion of area scaling from Combustion and Consumption spells by the amount of stacks earned by the Marks of Combustion/Consumption(this was achieved adjusting the spell in spell_dbc)
Normal Halion needs to be agressive and Twilight Halion needs to be Defensive
Twilight Halion needs UNIT_FLAG_COMBAT just after summon, to avoid health regeneration(checked in sniff)
Fixes summon of Living Embers(right timing, 3 seconds after Living Inferno spawn)
Implement proper evade, by despawning both Halions and the controller.
Fixed Blazing Aura issues
Fixed radius of the damage from combustion and consumption
Fixed all timers

Target branch(es): 335/6x

Issues addressed: Fixes #16599 #9231 #16700 #16626 #15154

Tests performed: (Does it build, tested in-game, etc) Yes.

Known issues and TODO list:

wanted to fix [3.3.5][6.x][RS] Halion Spells ( Meteor Strike & Fiery Combustion) #15154 too, but dunno how, if anyone has an idea, please, share
check phase two-three transition(bug caused by me?)
sniff halion's Orientation after wipe
Blazing Aura issues [3.3.5][6.x][Ruby] Halion - Blazing Aura issue #16626
timers
Twilight halion needs to run some events before aggro, check how to achiev that

Keader · 2016-03-04T23:46:44Z

👍

Treeston · 2016-03-05T01:13:45Z

Well, you know how this works.

While touching the boss script, you also get to sniff verify timers, spells et cetera and make sure it's hack free.

Enjoy!

sirikfoll · 2016-03-05T01:18:00Z

I won't be able to do much for this one, complexity way beyond my capabilities '-'

ccrs · 2016-03-05T01:25:58Z

also look into evading while at phase 2,3

nawuko · 2016-03-05T02:12:48Z

halion normal spawn pos:

[0] Position: X: 3156.67 Y: 533.8108 Z: 72.98822
[0] Orientation: 3.159046

halion after wipe spawn pos:

[1] Position: X: 3156.625 Y: 533.2674 Z: 72.97205
[1] Orientation: 0

Hope it helps 👍

sirikfoll · 2016-03-05T02:20:36Z

Thanks @nawuko ^^

Keader · 2016-03-05T13:07:02Z

#16626 Related with Halion Engage too :)

sirikfoll · 2016-03-05T19:39:16Z

Any suggestions on #15154 ?

Fiery Combustion (74562)
This area affected by this spell every second will get bigger and bigger, the visual part works
but the radius of damage part isn't updated.
http://imgur.com/NWhGegd

joschiwald · 2016-03-05T19:41:55Z

src/server/scripts/Northrend/ChamberOfAspects/RubySanctum/boss_halion.cpp

@@ -212,115 +212,28 @@ CorporealityEntry const _corporealityReference[MAX_CORPOREALITY_STATE] = {
    {74831, 74836}
 };

-struct generic_halionAI : public BossAI


why did you removed this base class?

didn't liked it, in the end there's even more duplicated code using this class than without it

What duplicated code was supposed to be gone with this removal? It seems to be adding duplicates rather than removing them

both bosses do not use the same timers for spells, that makes the genericAi useless

i will not merge this

well, feel free to close the PR or to commit some changes that looks right, I will not be changing this

What's logic to maintain a script that is not useful? No make any sense for me

ghost · 2016-03-06T01:04:34Z

src/server/scripts/Northrend/ChamberOfAspects/RubySanctum/boss_halion.cpp

+                while (uint32 eventId = events.ExecuteEvent())
+                    ExecuteEvent(eventId);
+
+                DoMeleeAttackIfReady();
            }

            void ExecuteEvent(uint32 eventId) override


is this function requires override ?

now it can be moved to inside UpdateAi, I will do that later ^^

Treeston · 2016-03-06T16:22:38Z

@sirikfoll look at how Grobbulus does it, it's the same mechanic.

sirikfoll · 2016-03-06T16:29:25Z

interesting, I was trying with https://gist.github.com/sirikfoll/b73c464392746dbe4011, probally just needs to create a formula then, thanks ^^

Treeston · 2016-03-06T16:32:35Z

If it actually has a stacking aura that tracks the progress, then that's the proper way to do it (and grobb is a hack). I haven't looked into it, admittedly.

sirikfoll · 2016-03-06T22:30:46Z

Alright, this is it, up to reviewing and testing.

ps: I will not be trying to fix corporeality, leave that for another brave soul

Shauren · 2016-03-06T22:52:19Z

src/server/scripts/Northrend/ChamberOfAspects/RubySanctum/boss_halion.cpp

                }

                _instance->SetBossState(DATA_HALION, FAIL);
+                _summons.DespawnAll();
+
+                uint32 corpseDelay = me->GetCorpseDelay();


use _DespawnAtEvade, now available in 3.3.5 branch

this npc doesn't use BossAI, dunno how to call it from here

ccrs · 2016-05-26T11:00:05Z

sometimes heroic spawns from the cutter orbs remain stationary instead of moving in circles after a wipe, have u checked that?

sirikfoll · 2016-05-26T11:45:39Z

Its rare, setActive(true), on the orb carrier solve that, but i'm pretty sure devs won't accept that

Treeston · 2016-05-26T11:46:48Z

SetActive(true) on engage and SetActive(false)reset is fine by me. BossAI does it too.

sirikfoll · 2016-05-26T12:00:15Z

@Treeston Since I don't know the cause to this problem, and the orbs are moving all the time, even when there's no boss in there, i can't confirm if that will solve the problem.
I just tested with a setActive in the constructor;

ccrs · 2016-05-26T13:38:04Z

its usually related to creatures entering combat, check that.

sirikfoll · 2016-06-10T03:40:56Z

@ccrs If you know how to reproduce the Shadow orbs problem, can you, please, test if this solve the issue? https://gist.github.com/sirikfoll/c3675e6d82a20edaef1f62bdce17b6a3

ccrs · 2016-06-10T19:50:58Z

Its quite random.. try to engage and reset till it happens.

Aokromes · 2016-06-12T06:53:52Z

Maybe this can be merged and the remain issues fixed on the future?

Treeston · 2016-06-12T11:33:07Z

We don't merge PRs that introduce new known issues.

sirikfoll · 2016-06-12T16:32:19Z

@Treeston What "new known issues" this pr introduces?
The problem with evade and with the Shadow Orbs are old things, and I presented solutions for both, only waiting for you guys decide if it can be used or not.

Warpten · 2016-06-23T08:49:55Z

src/server/scripts/Northrend/ChamberOfAspects/RubySanctum/boss_halion.cpp

@@ -1006,10 +1024,7 @@ class npc_meteor_strike_initial : public CreatureScript
                        me->SetOrientation(angle[i]);
                        Position newPos = me->GetNearPosition(10.0f, 0.0f); // Exact distance
                        if (Creature* meteor = me->SummonCreature(NPC_METEOR_STRIKE_NORTH + i, newPos, TEMPSUMMON_TIMED_DESPAWN, 30000))
-                        {
-                            meteor->SetOrientation(angle[i]);


I never tested those changes i did with the random adjusting because my pc is way too shitty but I clearly remember that this line was needed for the fire spread to go in the correct direction and not randomly fuck over the terrain (from when fire spread was linear, much like Marrowgar's). Now orientation is used to determine the randomness in the position of the next spawn (because direction 0 radians is always the same in world coordinates), so i'm not sure why this is gone?

Don't ask me why, i don't understood the code, it was basicaly trial and error haha.
But look at the results, shouldn't be like this?
http://prntscr.com/bkkl0s
http://prntscr.com/bkkkl7
http://prntscr.com/bkkkda
http://prntscr.com/bkkkl7
That static_cast<float>(M_PI / 5.0f), static_cast<float>(M_PI / 2.0f) makes this happen, the fire shapes between a cross and a X shape

ghost · 2016-07-04T07:12:51Z

@sirikfoll Could you confirm, Halion ( 25Man Mode ) should always drop a trinket,

http://www.truewow.org/forum/viewtopic.php?t=13613

sirikfoll · 2016-07-05T02:43:14Z

@Runico could be true, but I don't even know how to change the loot

ghost · 2016-07-05T14:50:46Z

@sirikfoll these querys works, but we just need confirm this is blizlike or not

DELETE FROM creature_loot_template WHERE entry IN(39864, 39945);
INSERT INTO creature_loot_template VALUES
(39864, 1, 100, 1, 0, -34282, 2),
(39864, 2, 100, 1, 0, -45100, 1),
(39864, 49426, 100, 1, 0, 3, 3),
(39945, 1, 100, 1, 0, -34283, 2),
(39945, 2, 100, 1, 0, -45101, 1),
(39945, 49426, 100, 1, 0, 3, 3);

DELETE FROM reference_loot_template WHERE entry IN(34282, 34283, 45100, 45101);
INSERT INTO reference_loot_template VALUES
(34282, 53125, 0, 1, 1, 1, 1),
(34282, 53126, 0, 1, 1, 1, 1),
(34282, 53127, 0, 1, 1, 1, 1),
(34282, 53129, 0, 1, 1, 1, 1),
(34282, 53132, 0, 1, 1, 1, 1),
(34282, 53133, 0, 1, 1, 1, 1),
(34282, 53134, 0, 1, 1, 1, 1),
(34282, 53486, 0, 1, 1, 1, 1),
(34282, 53487, 0, 1, 1, 1, 1),
(34282, 53488, 0, 1, 1, 1, 1),
(34282, 53489, 0, 1, 1, 1, 1),
(34282, 53490, 0, 1, 1, 1, 1),
(45100, 54569, 0, 1, 1, 1, 1),
(45100, 54571, 0, 1, 1, 1, 1),
(45100, 54572, 0, 1, 1, 1, 1),
(45100, 54573, 0, 1, 1, 1, 1),
(34283, 54576, 0, 1, 1, 1, 1),
(34283, 54587, 0, 1, 1, 1, 1),
(34283, 54586, 0, 1, 1, 1, 1),
(34283, 54585, 0, 1, 1, 1, 1),
(34283, 54584, 0, 1, 1, 1, 1),
(34283, 54583, 0, 1, 1, 1, 1),
(34283, 54582, 0, 1, 1, 1, 1),
(34283, 54581, 0, 1, 1, 1, 1),
(34283, 54580, 0, 1, 1, 1, 1),
(34283, 54579, 0, 1, 1, 1, 1),
(34283, 54578, 0, 1, 1, 1, 1),
(34283, 54577, 0, 1, 1, 1, 1),
(45101, 54591, 0, 1, 1, 1, 1),
(45101, 54590, 0, 1, 1, 1, 1),
(45101, 54589, 0, 1, 1, 1, 1),
(45101, 54588, 0, 1, 1, 1, 1);

Core/Scripts: Updates to Halion * Fixed Combustion and Consumption. * Fixed Living Embers and Blazing Auras. * Timer changes.

* Some codestyle fixes * Fixed wrong Halion summon with Hotswap system * Fixed evade issue * Fixed emblem frost exploit

Core/Scripts: Updates to Halion * Fixed Combustion and Consumption. * Fixed Living Embers and Blazing Auras. * Timer changes. (cherry picked from commit dfe2784) # Conflicts: # src/server/game/Spells/SpellMgr.cpp # src/server/scripts/Northrend/ChamberOfAspects/RubySanctum/boss_halion.cpp Fix sql for merged PR (cherry picked from commit 7f94469) Derp. github editor is bad. (cherry picked from commit 1829049)

sirikfoll force-pushed the Halion1 branch from f4d3e98 to 68907a5 Compare March 4, 2016 22:49

Aokromes added the Comp-C++Script label Mar 5, 2016

sirikfoll changed the title ~~Core/Scripts Corrections on Halion's Encounter~~ [WIP] Core/Scripts Corrections on Halion's Encounter Mar 5, 2016

joschiwald reviewed Mar 5, 2016
View reviewed changes

sirikfoll force-pushed the Halion1 branch from c36a4b2 to bb1dfca Compare March 5, 2016 21:29

ghost reviewed Mar 6, 2016
View reviewed changes

Aokromes added the Feedback-FixOutdatedMissingWIP label Mar 6, 2016

sirikfoll force-pushed the Halion1 branch 6 times, most recently from b8aa6aa to 2631084 Compare March 6, 2016 22:28

sirikfoll changed the title ~~[WIP] Core/Scripts Corrections on Halion's Encounter~~ Core/Scripts Corrections on Halion's Encounter Mar 6, 2016

sirikfoll force-pushed the Halion1 branch from 2631084 to 1e53c7e Compare March 6, 2016 22:34

Shauren reviewed Mar 6, 2016
View reviewed changes

Treeston added the Sub-Instances label Mar 7, 2016

Aokromes added Feedback-FixOutdatedMissingWIP and removed Feedback-PatchFix labels Jun 5, 2016

Warpten self-assigned this Jun 10, 2016

Aokromes mentioned this pull request Jun 14, 2016

Halion crepuscular miss spell ticket version 3 #8781

Closed

Aokromes added Feedback-PatchFix and removed Feedback-FixOutdatedMissingWIP labels Jun 15, 2016

Warpten reviewed Jun 23, 2016
View reviewed changes

Aokromes added Feedback-FixOutdatedMissingWIP and removed Feedback-PatchFix labels Jun 23, 2016

Warpten merged commit dfe2784 into TrinityCore:3.3.5 Jul 5, 2016

sirikfoll deleted the Halion1 branch July 5, 2016 14:52

Keader pushed a commit to Keader/TrinityCore that referenced this pull request Jul 10, 2016

Core/Scripts Corrections on Halion's Encounter (TrinityCore#16725)

7c93fc5

Core/Scripts: Updates to Halion * Fixed Combustion and Consumption. * Fixed Living Embers and Blazing Auras. * Timer changes.

Aokromes removed the Feedback-FixOutdatedMissingWIP label Aug 16, 2016

Keader referenced this pull request Dec 24, 2016

Core/Ruby: Minor fixes in Halion encounter

0b33a82

* Some codestyle fixes * Fixed wrong Halion summon with Hotswap system * Fixed evade issue * Fixed emblem frost exploit

Core/Scripts Corrections on Halion's Encounter #16725

Core/Scripts Corrections on Halion's Encounter #16725

Conversation

sirikfoll commented Mar 4, 2016

Keader commented Mar 4, 2016

Treeston commented Mar 5, 2016

sirikfoll commented Mar 5, 2016

ccrs commented Mar 5, 2016

nawuko commented Mar 5, 2016

sirikfoll commented Mar 5, 2016

Keader commented Mar 5, 2016

sirikfoll commented Mar 5, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Treeston commented Mar 6, 2016

sirikfoll commented Mar 6, 2016

Treeston commented Mar 6, 2016

sirikfoll commented Mar 6, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ccrs commented May 26, 2016

sirikfoll commented May 26, 2016

Treeston commented May 26, 2016

sirikfoll commented May 26, 2016 • edited

ccrs commented May 26, 2016

sirikfoll commented Jun 10, 2016

ccrs commented Jun 10, 2016

Aokromes commented Jun 12, 2016

Treeston commented Jun 12, 2016

sirikfoll commented Jun 12, 2016

Warpten Jun 23, 2016 • edited

Choose a reason for hiding this comment

sirikfoll Jun 24, 2016 • edited

Choose a reason for hiding this comment

ghost commented Jul 4, 2016

sirikfoll commented Jul 5, 2016

ghost commented Jul 5, 2016 • edited by ghost

sirikfoll commented May 26, 2016 •

edited

Warpten Jun 23, 2016 •

edited

sirikfoll Jun 24, 2016 •

edited

ghost commented Jul 5, 2016 •

edited by ghost