[6.x] Scripts/Spells: K'ure & Decimatus, SAI + spell scripts.

[ghost]

Changes proposed:

• Add Decimatus SAI
• Add Dark Siphon K'ure spell condition target.
• Add Decimatus Transformation Sickness spell script.

Target branch(es): 335/6x
6.x
Issues addressed: Fixes #
closes #16175
closes #15433
Tests performed: (Does it build, tested in-game, etc)
SAI and spell condition tested, spell script not tested.
Update:
Spell 169869 and 189491 testing in game, working, you can merge.
Known issues and TODO list:

• [6.x] Scripts/Spells: K'ure & Decimatus, SAI + spell scripts. #17343 (diff)
  Maybe this method better, or all right?
• Spell not have basepoint, used number value.

ID - 169869 Transformation Sickness
=================================================

ToolTip: Decimatus has been temporarily weakened by the premature transformation.
Category = 0, SpellIconID = 6176, activeIconID = 0, SpellVisual = (42387,0)
Family SPELLFAMILY_GENERIC, flag [0] 0x00000000 [1] 0x00000000 [2] 0x00000000 [3] 0x00000000

SpellSchoolMask = 1 (SPELL_SCHOOL_MASK_NORMAL)
DamageClass = 0 (SPELL_DAMAGE_CLASS_NONE)
PreventionType = 0 (SPELL_PREVENTION_TYPE_NONE)
=================================================
Attributes: 0x00000100 (SPELL_ATTR0_HIDE_IN_COMBAT_LOG)
=================================================
Spell Level = 0, base 0, max 0

Category = 0
DispelType = 0 (DISPEL_NONE)
Mechanic = 0 (MECHANIC_NONE)
SpellRange: (Id 1) "Self Only":
    MinRangeNegative = 0, MinRangePositive = 0
    MaxRangeNegative = 0, MaxRangePositive = 0

Cast time (Id 1) = 0,00
Duration: ID (21)  -1, 0, -1
Interrupt Flags: 0x00000000, AuraIF 0x00000000, ChannelIF 0x00000000
Chance = 0, charges - 0
=================================================
Effect 0: Id 6 (SPELL_EFFECT_APPLY_AURA) DIFFICULTY_NONE
BasePoints = 0
Targets (1, 0) (TARGET_UNIT_CASTER, NO_TARGET)
Aura Id 4 (SPELL_AURA_DUMMY), value = 0, misc = 0 (0), miscB = 0, periodic = 0

Effect 1: Id 77 (SPELL_EFFECT_SCRIPT_EFFECT) DIFFICULTY_NONE
BasePoints = 0
Targets (1, 0) (TARGET_UNIT_CASTER, NO_TARGET)

NOTE If your Pull Request is SQL only create a ticket instead

SUGESTION If your Pull Request contains SQL give it one imposible date, for example 9999_99_99_99_database.sql on that way it will be free on merge.

[Keader]

Sql name.
Should conflict when merge.

[Aokromes]

Na, it won't, no one merged db content on 6.x branch that day.

[ghost]

void HandleScript(SpellEffIndex /effIndex/)
{
if (Unit* caster = GetCaster())
uint32 hp = caster->CountPctFromMaxHealth(10);
if (hp)
caster->SetHealth(hp);
}
Maybe this better? Also add in database HealthRegen interrupt flag.

[MitchesD]

caster can't be null there, so useless check

[ghost]

caster can't be null there, so useless check

Okay, you can suggested new variant? See below.
Variant 1:

        void HandleScript(SpellEffIndex /*effIndex*/)
         {
             GetCaster()->SetHealth(GetCaster()->CountPctFromMaxHealth(10));
         }

Or variant 2:

void HandleScript(SpellEffIndex /*effIndex*/)
        {
            if (Unit* target = GetHitUnit())
               target->SetHealth(target->CountPctFromMaxHealth(10));
        }

Right?

[ghost]

Sql name.
Should conflict when merge.

Don't worry, I was staring sql date before add file.