Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Kalecgos evade condition. #17631

Merged
merged 2 commits into from Nov 27, 2016
Merged

The Kalecgos evade condition. #17631

merged 2 commits into from Nov 27, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2016

Changes proposed:

  • Kalecgos evade condition.

- Proof http://us.battle.net/wow/en/blog/8896363#raids_dungeons

Target branch(es): 335/6x
6.x only.
Issues addressed: Closes #
Not.
Tests performed: (Does it build, tested in-game, etc)
Not testing.
Known issues and TODO list:

NOTE If your Pull Request is SQL only create a ticket instead

SUGESTION If your Pull Request contains SQL give it one imposible date, for example 9999_99_99_99_database.sql on that way it will be free on merge.

The Kalecgos encounter in The Sunwell can now be completed by a single player

The Kalecgos encounter in The Sunwell can now be completed by a single player
@Ovahlord
Copy link
Contributor

Ovahlord commented Jul 19, 2016

I would put this right under the if(!UpdateVicitim()) check in UpdateAI. this one here will cause the encounter to break things if the evade is called by an wipe while the aura was applied.

@ghost
Copy link
Author

ghost commented Jul 19, 2016

Maybe you are right, but Kalecgos can cast spell SPECTRAL_BLAST on player, even if has aura banish.
AttributesEx5: 0x00000008 (SPELL_ATTR5_USABLE_WHILE_STUNNED)

@Ovahlord
Copy link
Contributor

it is more that everything after that check like

             bJustReset = true;
              me->SetVisible(false);
              me->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NON_ATTACKABLE + UNIT_FLAG_NOT_SELECTABLE);

and so on is getting fucked up if he evades due to an wipe and has that aura.

@ghost
Copy link
Author

ghost commented Jul 21, 2016

Banish aura not removed in script. Event cannot be completed even without evade condition. But after wipe cleanup working.

@DDuarte DDuarte changed the base branch from 6.x to master October 16, 2016 16:50
@@ -171,6 +171,9 @@ class boss_kalecgos : public CreatureScript

void EnterEvadeMode(EvadeReason why) override
{
if (me->HasAura(SPELL_BANISH))
return;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove whitespaces :)

@Aokromes Aokromes merged commit b8ef846 into TrinityCore:master Nov 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants