Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Instance: Fix GetInstanceSave sometimes checking the wrong map #17856

Merged
merged 1 commit into from Aug 25, 2016
Merged

Conversation

roc13x
Copy link
Contributor

@roc13x roc13x commented Aug 24, 2016

Changes proposed:

  • Always check the correct map ID in GetInstanceSave. If the player was in a group, it would check for a save on the players current map instead of the requested mapID

Target branch(es): 3.3.5/6.x

Tests performed: Builds, works correctly ingame

@jackpoz
Copy link
Member

jackpoz commented Aug 25, 2016

thank you for the fix. do you know if this solves any known issue too ?

@ghost
Copy link

ghost commented Aug 25, 2016

Any chance this helps with #15780 ?

@roc13x
Copy link
Contributor Author

roc13x commented Aug 25, 2016

I don't know of any reported issues on the tracker, but it affected the "change dungeon entrance" feature on 6.x (you could no longer exit an instance through the portal)

@Nyeriah It wouldn't help with that, but I am currently testing a fix for that bug and will PR if it works

joschiwald pushed a commit that referenced this pull request Feb 18, 2017
conan513 pushed a commit to conan513/SingleCore_TC that referenced this pull request Mar 13, 2017
Krudor pushed a commit to Krudor/TrinityCore that referenced this pull request Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants