Add additional faction check before completing an achievement #18436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing achievements of both factions if they use the same criteria.
ghost
added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Some faction specific achievements use the same criteria for both factions.
The core only checks the faction when deciding which critera should be updated. When the criteria tree is complete it gives the corresponding achievement without an additional faction check. So you get both the Horde and Alliance achievement.
Target branch(es): 3.3.5/master
Tests performed: (Does it build, tested in-game, etc.)
Tested in-game with achievements 2536/2537 (Mountain o' Mounts)