Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Scripts: fix Priest spell Power Word: Shield #19199

Closed

Conversation

HannibalRoG
Copy link
Contributor

@HannibalRoG HannibalRoG commented Feb 25, 2017

Changes proposed:

Fix priest spell Power Word: Shield, based on comments from Shauren.

Target branch(es): 3.3.5/master

  • master

Issues addressed: Closes # (insert issue tracker number)

Tests performed: (Does it build, tested in-game, etc.)
Compiled and tested in game.

@Aokromes Aokromes changed the title Fix spell Priest Power word: Shield from comments of @Shauren Fix spell Priest Power word: Shield Feb 25, 2017
Unit* caster = GetCaster();
Unit* target = GetTarget();

if (!caster || !target)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target never null

}

void HandleOnRemove(const AuraEffect* aurEff, AuraEffectHandleModes /*mode*/)
{
if (Player* player = GetCaster()->ToPlayer())
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace

@ghost ghost changed the title Fix spell Priest Power word: Shield Core/Scripts: fix Priest spell Power Word: Shield Feb 27, 2017
@Shauren Shauren closed this in a36f34a Mar 11, 2017
@HannibalRoG HannibalRoG deleted the Priest_Fix_ShaurenSaid branch March 11, 2017 18:12
conan513 pushed a commit to conan513/SingleCore_TC that referenced this pull request Mar 13, 2017
Krudor pushed a commit to Krudor/TrinityCore that referenced this pull request Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants