New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core/Scripts: fix Priest spell Power Word: Shield #19199
Closed
HannibalRoG
wants to merge
2
commits into
TrinityCore:master
from
HannibalRoG:Priest_Fix_ShaurenSaid
Closed
Core/Scripts: fix Priest spell Power Word: Shield #19199
HannibalRoG
wants to merge
2
commits into
TrinityCore:master
from
HannibalRoG:Priest_Fix_ShaurenSaid
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aokromes
changed the title
Fix spell Priest Power word: Shield from comments of @Shauren
Fix spell Priest Power word: Shield
Feb 25, 2017
joschiwald
reviewed
Feb 25, 2017
Unit* caster = GetCaster(); | ||
Unit* target = GetTarget(); | ||
|
||
if (!caster || !target) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target never null
joschiwald
reviewed
Feb 25, 2017
} | ||
|
||
void HandleOnRemove(const AuraEffect* aurEff, AuraEffectHandleModes /*mode*/) | ||
{ | ||
if (Player* player = GetCaster()->ToPlayer()) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace
ghost
changed the title
Fix spell Priest Power word: Shield
Core/Scripts: fix Priest spell Power Word: Shield
Feb 27, 2017
conan513
pushed a commit
to conan513/SingleCore_TC
that referenced
this pull request
Mar 13, 2017
Krudor
pushed a commit
to Krudor/TrinityCore
that referenced
this pull request
Jul 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Fix priest spell Power Word: Shield, based on comments from Shauren.
Target branch(es): 3.3.5/master
Issues addressed: Closes # (insert issue tracker number)
Tests performed: (Does it build, tested in-game, etc.)
Compiled and tested in game.