Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts/Quest: The Missing Diplomat part 14 (ID 1265) #20619

Merged
merged 5 commits into from Oct 29, 2017

Conversation

PolarCookie
Copy link
Contributor

Changes proposed:
Archmage Tervosh will teleport to Sentry Point, Dustwallow Marsh, if approaching with The Missing Diplomat pt14 (id:1265) in the log. He'll give a little buff when you turn in this quest and say a line.

https://www.youtube.com/watch?v=6XeuwJnqSd4&feature=youtu.be&t=5m11s

Tervosh will teleport in by an areatrigger at the top of the ramp, the quest objective areatrigger is inside the tower

Target branch(es):

  • 3.3.5

Tests performed: tested in-game.

Known issues and TODO list:

  • Find the correct teleport spell, video looks flashier.

@ghost ghost changed the title [quest] The Missing Diplomat (part 14, id 1265) Scripts/Quest: The Missing Diplomat part 14 (ID 1265) Oct 15, 2017
@ghost
Copy link

ghost commented Oct 15, 2017

@Aokromes
Copy link
Member

@Keader this can be merged?


bool OnTrigger(Player* player, AreaTriggerEntry const* /*trigger*/)
{
auto quest_status = player->GetQuestStatus(QUEST_MISSING_DIPLO_PT14);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change auto to correct type please.

@Aokromes Aokromes merged commit cfc0944 into TrinityCore:3.3.5 Oct 29, 2017
@PolarCookie PolarCookie deleted the the_missing_diplomat_1265 branch January 1, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants