Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts/Scarlet Enclave: Grand Theft Palomino #22967

Merged
merged 3 commits into from Feb 2, 2019
Merged

Scripts/Scarlet Enclave: Grand Theft Palomino #22967

merged 3 commits into from Feb 2, 2019

Conversation

Sorikoff
Copy link
Contributor

@Sorikoff Sorikoff commented Jan 19, 2019

Changes proposed:
Based on #20897 quest Grand Theft Palomino implementation.

Target branch(es): 3.3.5

Issues addressed: Closes #20844

Tests performed: Does build, works-in-game

Known issues and TODO list:

@ghost
Copy link

ghost commented Jan 20, 2019

I am glad to see the script become event driven instead of a bunch of loose (and often vulnerable to change) timer calls.

@burbur
Copy link

burbur commented Jan 22, 2019

Nice one!
Glad to see you have followed the original work and finished the script with some improvements. Thank you!

I've abandoned the pull request because I could not follow every (right) modification request from trinity staff due to work duties! :)
I apologize with the people who were rewieving it because I've forgot about it after a while.

@jackpoz
Copy link
Member

jackpoz commented Feb 2, 2019

@Keader any change left to do before merging this ?

@jackpoz jackpoz merged commit d5f565f into TrinityCore:3.3.5 Feb 2, 2019
@jackpoz
Copy link
Member

jackpoz commented Feb 2, 2019

Thanks for the PR :)

@Sorikoff Sorikoff deleted the 3.3.5-grandtheft branch February 3, 2019 07:49
Aokromes pushed a commit to Aokromes/TrinityCore that referenced this pull request Feb 18, 2019
* Grand Theft Palomino

* Cosmetic issues

* Address CR
Shauren pushed a commit that referenced this pull request Nov 23, 2021
* Grand Theft Palomino

* Cosmetic issues

* Address CR

(cherry picked from commit d5f565f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants