Core/Loot: fix some issues with master loot and don't allow players to see soulbound recipes that they already learned in the loot window #23410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wyrserth
force-pushed
the
soulbound_recipes_loot
branch
from
63b2df4
to
029f8eb
Compare
Wyrserth
changed the title
…o see soulbound recipes that they already learned in the loot window.
Wyrserth
force-pushed
the
soulbound_recipes_loot
branch
from
029f8eb
to
b34196e
Compare
|
Thanks for the PR :) |
Aokromes
added a commit
to Aokromes/TrinityCore
that referenced
this pull request
Jun 15, 2019
…o see soulbound recipes that they already learned in the loot window. (TrinityCore#23410)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
This PR implements the following changes:
Allow the master looter to see quest items and recipes regardless of quest status/profession/skill level. Giving the item to any player is still subjected to the usual restrictions.
Don't send an error message to the player receiving the loot - only the master looter should see an error if the target player can't receive the item.
Soulbound recipes that the player already learned should not show in loot windows anymore.
Affects items like Manual: Heavy Frostweave Bandage and A Guide to Northern Cloth Scavenging.
Target branch(es): 3.3.5/master
Issues addressed: fixes #16653, updates #12004.
Tests performed: it works.