Scripts/Ebon Hold: Bloody Breakout

[Sorikoff]

Changes proposed:

Rework existing script.

• Move some parts to SAI.
• Improve intro/outro.
• Add/correct missing gossips, flags, movements, timers, IDs...

Target branch(es): 3.3.5

Issues addressed:

Tests performed: Works good in overall.

[Sorikoff]

Could someone help with a couple of issues?

1. The following texts doesn't play their emotes.

(28912,7,0,'The death of the High Inquisitor of New Avalon will not go unnoticed. You need to get out of here at once! Go, before more of them show up. I''ll be fine on my own.',12,0,100,1,0,0,29239,0,'Koltira Deathweaver'),
(28912,8,0,'I''ll draw their fire, you make your escape behind me.',12,0,100,1,0,0,29240,0,'Koltira Deathweaver'),
(28912,9,0,'Your High Inquisitor is nothing more than a pile of meat, Crusaders! There are none beyond the grasp of the Scourge!',14,0,100,22,0,0,29241,0,'Koltira Deathweaver');

2. Koltira does not despawn on reaching point 10 (I use me->DespawnOrUnsummon()).

[Killyana]

For the despawn you can put 1188 as action in the last point, but better to find why me->DespawnOrUnsummon() is not working before.

[Sorikoff]

Works good in overall now. Some minor issues are still present but they were there with the original script too tho (like emotes).
Also using waypoints from Cmangos now.

[ghost]

Looks good to me.

[Killyana]

Emotes are not played because they are override by me->SetByteValue

[ghost]

Does that mean they could be played if that line is removed in the script while the values are set in the DB or by SAI?

[Sorikoff]

The first emote (first text) is playing I think but bytes are being set.

[Killyana]

No Idea in this case

[ghost]

Maybe a timing issue, as noted in #22287 ?

[Killyana]

There's a missing text: "Stay in the anti-magic field! Make them come to you!" , 29225
And Koltira must equip his weapon.
Otherwise, it look good

[Sorikoff]

Added lines.

[jackpoz]

what's the status with this PR ?

[Killyana]

Need I final test, and maybe check the cpp.

[Killyana]

Everything looks fine except in case the player dies, I think in this case it's better to despawn Koltira and every summoned npc, and set the quest to failed.
Also change the respawn time of Koltira to 1min instead of 6

Also if the player leave the area a reset must happen.

[Sorikoff]

Everything looks fine except in case the player dies, I think in this case it's better to despawn Koltira and every summoned npc, and set the quest to failed.

Isn't Reset called in such case?

[Killyana]

When I died the script kept going an summoning npcs.

[Sorikoff]

Added 5 sec check (until outro events) that will despawn Koltira && summons if player is dead/30m from Koltira).

[Killyana]

In which case: void Reset() overridevoid Reset() override will be triggered ?

[Sorikoff]

At respawn.

[Killyana]

It looks good, it can be merge

[ghost]

Cosmetic/codestyle: 8 space indent is slightly redundant. Reduce to 4 ?

[ghost]

Maybe this is a proper time to consider adding the commit 9009c82 to make ci/circleci: nopch work again, or choose to rebase this PR branch on the current 3.3.5 TC branch, if you prefer that instead.

[jackpoz]

Thanks for the PR :)