Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts/Silverpine: Fixed Nowhere to Run (questId 27195) #28404

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Nyr97
Copy link
Contributor

@Nyr97 Nyr97 commented Oct 25, 2022

Changes proposed:

  • Scripted RP event for Nowhere to Run (questId 27195).
  • Added missing spawns in Deep Elem Mine.
  • Added visibility conditions for spawns.

Issues addressed:

None.

Tests performed:

It builds and it was tested in-game.

Known issues and TODO list:

  • Formation and MoveFollow are deadly wrong because we require a FormationMovementGenerator and FollowMovementGenerator rework (or cherrypick 434's branch one). That's the reason why the troopers' movement is so clunky. In any case, I'm keeping a register of things that I might improve and keep updated once certain new implementations get added.
  • Toss Bomb (spellId 84467) isn't able to find an appropriate target even if the condition is correctly set or a wider RangeIndex is added to the spell. In any case, there's no npcTrigger or gameobject to be found to be used as entry for TARGET_DEST_NEARBY_ENTRY. The bomb is spawned after SPELL_GO is sent, so it cannot be the entry. I changed TargetA to TARGET_DEST_DB instead.
  • Toss Bomb (spellId 84468) uses SPELL_EFFECT_SEND_EVENT which is unusable in TC. I changed it to serve a better purpose as SPELL_EFFECT_SUMMON.

* fixed a bug where Master Forteski would be immune to NPC during the RP event.
* fixed a bug where Master Forteski would be able to reward quest during the RP event.
* simplified the RP event.
* hacked two spells.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants