Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB/Creatures: detach non-wdb data from creature_template part 1: difficulty entries #28947

Open
wants to merge 1 commit into
base: 3.3.5
Choose a base branch
from

Conversation

Ovahlord
Copy link
Contributor

@Ovahlord Ovahlord commented Apr 27, 2023

Changes proposed:
this marks the beginning of a long overdue task: relocating data which isn't sent in query packets for creatures into separate tables. This means that when this journey is over, we can call creature_template sacred so no user may touch the table ever again just like we do with gameobject_template.

Tests performed:

  • none yet.

…iculty entries

* moved difficulty entries to a own table
@Ovahlord Ovahlord changed the title DB/Creatures: detach non-wdb data from creature_template part 1: diff… DB/Creatures: detach non-wdb data from creature_template part 1: difficulty entries Apr 27, 2023
@Shauren
Copy link
Member

Shauren commented Apr 27, 2023

I actually disagree with tiny splits like what you propose here for 1:1 relations, it makes dealing with tables very annoying

@Ovahlord
Copy link
Contributor Author

Ovahlord commented Apr 27, 2023

Well, i'm currently thinking about migrating difficulty into creature_template_addon to get closer to what gameobject_template does and only create a new table for stats (level, faction, speeds etc) instead. the main goal in the end is to have a table with clean wdb data like we do have with quest_template and gameobject_template. creature_template is the only table which falls out of this pattern

@Nyr97
Copy link
Contributor

Nyr97 commented Apr 27, 2023

isn't it best to move it into creature_template_difficulty instead? _addon table should resemble as much as master's, and master's difficulties are handled in _scaling table which is non-existent in wotlk branches, this would be the counterpart to _scaling table.

@funjoker
Copy link
Member

IMO creature_template should only contain data from QUERY_RESPONSE and any other data taken from UFs or else should go to addon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants