Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core/Auras: updated spell aura flags and implemented AFLAG_CANCELABLE and AFLAG_PASSIVE #29634

Merged
merged 1 commit into from Jan 30, 2024
Merged

Core/Auras: updated spell aura flags and implemented AFLAG_CANCELABLE and AFLAG_PASSIVE #29634

merged 1 commit into from Jan 30, 2024

Conversation

Ovahlord
Copy link
Contributor

Changes proposed:

  • based on discord discussions it appears that the classic aura flags are different from retail. After comparing the information with sniffs, it seems that these informations are legit.

Tests performed:

  • tested ingame

However, we could need a reversing guy digging into the depths of the client to verify that classic uses other flags than retail does

@Ovahlord Ovahlord merged commit a629fe5 into TrinityCore:wotlk_classic Jan 30, 2024
6 checks passed
Ovahlord added a commit that referenced this pull request Mar 19, 2024
@Ovahlord
Core/Auras: updated spell aura flags and implemented AFLAG_CANCELABLE…
30bf56d 
… and AFLAG_PASSIVE (#29634)

(cherry picked from commit a629fe5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Branch-wotlk_classic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ovahlord