Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wandering isle quest 29419 #29821

Merged
merged 16 commits into from Apr 12, 2024

Conversation

aquadeus
Copy link
Contributor

Changes proposed:

  • Script quest 29419 blizzlike

Tests performed:

Tested in-game

Known issues and TODO list: (add/remove lines as needed)

  • Npcs Amberleaf scamp should walk/run randomly when random movement is set and walk when movetargetedhome is set

@Aokromes
Copy link
Member

Conflicting files
src/server/scripts/Pandaria/zone_the_wandering_isle.cpp

@aquadeus
Copy link
Contributor Author

Conflicting files src/server/scripts/Pandaria/zone_the_wandering_isle.cpp

done

@@ -680,7 +680,7 @@ class at_min_dimwind_captured : public AreaTriggerScript
return false;

minDimwind->CastSpell(player, SPELL_FORCE_SUMMON_CART_DRIVER, TRIGGERED_FULL_MASK);
player->CastSpell(player, SPELL_SERVERSIDE_KILL_CREDIT, TRIGGERED_FULL_MASK);
player->CastSpell(player, SPELL_SERVERSIDE_DRIVER_CREDIT, TRIGGERED_FULL_MASK);
Copy link
Member

@Shauren Shauren Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shows the PR was untested after resolving merge conflicts

@Shauren Shauren merged commit a3f760e into TrinityCore:master Apr 12, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants