New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wandering isle quest 29419 #29821
Merged
Shauren
merged 16 commits into
TrinityCore:master
from
aquadeus:wandering_isle_quest_29419
Apr 12, 2024
Merged
Wandering isle quest 29419 #29821
Shauren
merged 16 commits into
TrinityCore:master
from
aquadeus:wandering_isle_quest_29419
Apr 12, 2024
+340
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdX7
requested changes
Mar 26, 2024
Shauren
reviewed
Mar 27, 2024
Shauren
requested changes
Apr 8, 2024
Shauren
reviewed
Apr 11, 2024
Conflicting files |
done |
Shauren
reviewed
Apr 12, 2024
@@ -680,7 +680,7 @@ class at_min_dimwind_captured : public AreaTriggerScript | |||
return false; | |||
|
|||
minDimwind->CastSpell(player, SPELL_FORCE_SUMMON_CART_DRIVER, TRIGGERED_FULL_MASK); | |||
player->CastSpell(player, SPELL_SERVERSIDE_KILL_CREDIT, TRIGGERED_FULL_MASK); | |||
player->CastSpell(player, SPELL_SERVERSIDE_DRIVER_CREDIT, TRIGGERED_FULL_MASK); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this shows the PR was untested after resolving merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Tests performed:
Tested in-game
Known issues and TODO list: (add/remove lines as needed)