Core/Creatures: Allow profession tools to be used as equipment #29915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shauren
reviewed
Apr 13, 2024
| @@ -415,6 +415,20 @@ enum InventoryType : uint8 | |||
|
|
|||
| #define MAX_INVTYPE 35 | |||
|
|
|||
| constexpr std::array<InventoryType, 10> InventoryTypesEquipable = | |||
There was a problem hiding this comment.
Eh, making it local in ObjectMgr::LoadEquipmentTemplates seems fine (I don't see another use for this)
There was a problem hiding this comment.
True, I don't know why I was thinking about validations for SAI. Fixed
There was a problem hiding this comment.
Maybe because SAI can set random items (not validated) if action_param1 = 0
There was a problem hiding this comment.
Sooo... should I move it back to where I put it? I don't like the idea of being able to try to equip any item in that SAI action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Issues addressed:
None
Tests performed:
Builds, tested in-game: Lee Sunspark
Known issues and TODO list: (add/remove lines as needed)
None