Core/Spells: Fixed logic for GetSpellXSpellVisualId

[mdX7]

• fixes some spell visuals not being shown

Info:
Due to the previous code creatures would always reach !caster->IsPlayer() which would result in skipping the loop iteration and ultimatively returning 0 as spell visual.

        if (!caster || !caster->IsPlayer() || !ConditionMgr::IsPlayerMeetingCondition(caster->ToPlayer(), visual->CasterPlayerConditionID))
            continue;

Alternative solution:

        if (!caster || (caster->IsPlayer() && !ConditionMgr::IsPlayerMeetingCondition(caster->ToPlayer(), visual->CasterPlayerConditionID)))
            continue;

Tests performed:
built, tested ingame with spellids 111217 and 111219

[aquadeus]

this fixes spell 56745 too

[Shauren]

Original code (before 4913d02) skipped the visual if it had a playercondition and caster wasnt a player