Implemented OnHeartbeat AuraScript hook and refactored an aurascript to use it as example #29945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shauren
reviewed
Apr 27, 2024
Nyr97
reviewed
Apr 27, 2024
| @@ -4345,7 +4337,7 @@ class spell_item_amalgams_seventh_spine : public AuraScript | |||
| if (target->GetPrimarySpecialization() != spec) | |||
| target->RemoveAurasDueToSpell(aura); | |||
| else if (!target->HasAura(aura)) | |||
| target->CastSpell(target, aura, aurEff); | |||
| target->CastSpell(target, aura, GetEffect(EFFECT_0)); | |||
There was a problem hiding this comment.
Would we not need to validate this effect since OnHeartbeat is not really hooking any and implicitly validating any?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
Tests performed: