Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Combat: reset the ThreatManager update interval upon engaging thee creature and move ThreatClear packet sending into the update cycle to mimic retail behavior #29949

Merged
merged 1 commit into from May 2, 2024

Conversation

Ovahlord
Copy link
Contributor

Changes proposed:

  • the threatmanager will now continue to update even when dead to support sending pending packets when dead
  • TheatClear is now put behind the threat update interval to mimic retail
  • This fixes an inconsistency in the client where HighestThreatUpdate and ClearTheat would be sent at the same time, resulting in the creature retaining the threat display, causing the client to glitch out and being stuck in this red'ish state

Tests performed:

  • tested ingame

Known issues and TODO list: (add/remove lines as needed)

  • This treatment should also be applied for the CombatManager as the combat and threat update but should happen at the same time.

…e creature and move ThreatClear packet sending into the update cycle to mimic retail behavior
@Shauren Shauren merged commit 24bda9c into TrinityCore:master May 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants